[Testing] Added tests to validate the ItemsUpdatingScrollMode property in CarouselView#26160
Closed
jsuarezruiz wants to merge 8 commits intomainfrom
Closed
[Testing] Added tests to validate the ItemsUpdatingScrollMode property in CarouselView#26160jsuarezruiz wants to merge 8 commits intomainfrom
jsuarezruiz wants to merge 8 commits intomainfrom
Conversation
Member
|
/rebase |
7db0d12 to
27d36e5
Compare
rmarinho
requested changes
Dec 10, 2024
Member
rmarinho
left a comment
There was a problem hiding this comment.
Test is failing in several platforms
Contributor
Author
|
/rebase |
27d36e5 to
d3a936e
Compare
Contributor
Author
|
The default value for the ItemsUpdatingScrollMode property is KeepItemsInView So, by default, the CarouselView should move the scroll to the first item after add a new one. That happens on Windows, after merge c3f42a9 In the added UITest we can validate the behavior with the three enum options:
However, as described in the issue, on Android the position is maintained by default. That's wrong. However, more than fix the Windows behavior, seems like it is wrong on other platforms. @Tamilarasan-Paranthaman Could you check the tests results and align/fix the behavior between platforms? Close in favor of #26608 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Added tests to validate the ItemsUpdatingScrollMode property in CarouselView.
Issues Fixed
Related with #25991