[Android] IndicatorView with DataTemplate (custom image) does not render correctly when ItemsSource change#24717
Closed
NanthiniMahalingam wants to merge 19 commits intodotnet:mainfrom
Closed
[Android] IndicatorView with DataTemplate (custom image) does not render correctly when ItemsSource change#24717NanthiniMahalingam wants to merge 19 commits intodotnet:mainfrom
NanthiniMahalingam wants to merge 19 commits intodotnet:mainfrom
Conversation
Contributor
|
Hey there @NanthiniMahalingam! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
mattleibow
reviewed
Sep 11, 2024
Member
mattleibow
left a comment
There was a problem hiding this comment.
Just adding a comment about the test and not actually reviewing the code yet.
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
PureWeen
requested changes
Sep 24, 2024
Member
PureWeen
left a comment
There was a problem hiding this comment.
I tested with the users sample and PR here
And noticed that with just the fix in this PR that the width of the indicator view stays incorrect
where as with the other PR the size seems to update
Can you review #24776 and see if those changes makes sense or if you have thoughts on a different approach?
Contributor
Author
|
The changes added in the other PR (#24776) is fine. |
Member
Closing in favor of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root Cause
Description of Change
After adding the Update indicator view template in UpdatingIndcatorCount method for mapping the Count property in IndicatorViewHandler android class, indicator view data template does not mess up.
Issues Fixed
Fixes #21980
Output:
Android Platform
Before changes:
IndicatorView_BeforeChanges.mp4
After changes:
IndicatorView_AfterChanges.mp4