Skip to content

Fixed the CollectionView GroupFooterTemplate crashes the application#24205

Merged
PureWeen merged 10 commits intodotnet:mainfrom
NanthiniMahalingam:fix-18702
Aug 26, 2024
Merged

Fixed the CollectionView GroupFooterTemplate crashes the application#24205
PureWeen merged 10 commits intodotnet:mainfrom
NanthiniMahalingam:fix-18702

Conversation

@NanthiniMahalingam
Copy link
Copy Markdown
Contributor

@NanthiniMahalingam NanthiniMahalingam commented Aug 13, 2024 •
edited by samhouts
Loading

Root cause:

  • When GroupFooterTemplate item has list of items. The list of items tried to add to the collection view item source.
  • It thrown the argument exception while adding the list of items into items source at collection changed event hooked.

Description of Change

  • If GroupFooterTemplate item has list of items, we need to add the group footer items hard way

Issues Fixed

Fixes #18702

ScreenShots

Before changes

CrashOutput

After changes

Output

@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Aug 13, 2024
@NanthiniMahalingam NanthiniMahalingam changed the title Defining CollectionView GroupFooterTemplate crashes the app #18702 Defining CollectionView GroupFooterTemplate crashes the app Aug 13, 2024
@rmarinho rmarinho requested a review from Foda August 13, 2024 10:52
Foda
Foda previously approved these changes Aug 13, 2024
View reviewed changes
@PureWeen
Copy link
Copy Markdown
Member

PureWeen commented Aug 18, 2024 •
edited by jfversluis
Loading

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Aug 18, 2024

Azure Pipelines successfully started running 3 pipeline(s).

@NanthiniMahalingam NanthiniMahalingam changed the title Defining CollectionView GroupFooterTemplate crashes the app Fixed the CollectionView GroupFooterTemplate crashes the application Aug 19, 2024
@MartyIX
Copy link
Copy Markdown
Contributor

MartyIX commented Aug 19, 2024

@NanthiniMahalingam I think you need to accept CLA here on your behalf (or your company): #24205 (comment)

@NanthiniMahalingam NanthiniMahalingam marked this pull request as ready for review August 22, 2024 08:05
@NanthiniMahalingam NanthiniMahalingam requested a review from a team as a code owner August 22, 2024 08:05
@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Aug 22, 2024

Azure Pipelines successfully started running 3 pipeline(s).

@NanthiniMahalingam
Copy link
Copy Markdown
Contributor Author

NanthiniMahalingam commented Aug 22, 2024

@dotnet-policy-service agree

@jfversluis
Copy link
Copy Markdown
Member

jfversluis commented Aug 22, 2024

I think we need to update the snapshot for this one @NanthiniMahalingam you know how to do that? If not, please reach out!

@NanthiniMahalingam
Copy link
Copy Markdown
Contributor Author

NanthiniMahalingam commented Aug 23, 2024

@jfversluis , Updated the snapshot.

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Aug 23, 2024

Azure Pipelines successfully started running 3 pipeline(s).

@PureWeen PureWeen requested a review from Foda August 23, 2024 15:39
@PureWeen PureWeen merged commit aa1632a into dotnet:main Aug 26, 2024
@samhouts samhouts added the fixed-in-net8.0-nightly This may be available in a nightly release! label Aug 27, 2024
@samhouts samhouts added the fixed-in-net9.0-nightly This may be available in a nightly release! label Sep 5, 2024
@NirmalKumarYuvaraj NirmalKumarYuvaraj mentioned this pull request Sep 23, 2024
Merged
4 tasks
@samhouts samhouts added fixed-in-9.0.0-rc.2.24503.2 and removed fixed-in-net9.0-nightly This may be available in a nightly release! fixed-in-net8.0-nightly This may be available in a nightly release! labels Oct 14, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Nov 16, 2024
@sheiksyedm sheiksyedm added the partner/syncfusion Issues / PR's with Syncfusion collaboration label Dec 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@PureWeen PureWeen PureWeen approved these changes

@jfversluis jfversluis Awaiting requested review from jfversluis jfversluis was automatically assigned from dotnet/dotnet-maui-reviewers

@tj-devel709 tj-devel709 Awaiting requested review from tj-devel709 tj-devel709 was automatically assigned from dotnet/dotnet-maui-reviewers

+1 more reviewer

@Foda Foda Foda approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Foda Foda

Labels

community ✨ Community Contribution fixed-in-9.0.0-rc.2.24503.2 partner/syncfusion Issues / PR's with Syncfusion collaboration platform/windows

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Windows] Defining CollectionView GroupFooterTemplate crashes the app

7 participants

@NanthiniMahalingam @PureWeen @MartyIX @jfversluis @Foda @samhouts @sheiksyedm