Skip to content

[Binding SG] Split bindings source generated code into multiple files#23116

Merged
simonrozsival merged 10 commits intodotnet:net9.0from
jkurdek:split-generated-code-into-multiple-files
Jul 2, 2024
Merged

[Binding SG] Split bindings source generated code into multiple files#23116
simonrozsival merged 10 commits intodotnet:net9.0from
jkurdek:split-generated-code-into-multiple-files

Conversation

@jkurdek
Copy link
Copy Markdown
Contributor

@jkurdek jkurdek commented Jun 18, 2024 •
edited by PureWeen
Loading

Description of Change

This is a follow-up to #21725, contributes to #22384

This change generates each SetBinding in a separate file allowing for more granular caching.

FIXES

#23551

@jkurdek jkurdek requested a review from a team as a code owner June 18, 2024 13:25
@jkurdek jkurdek requested review from PureWeen and rmarinho June 18, 2024 13:25
@jkurdek jkurdek changed the title Split Bindings source generated code into multiple files Split bindings source generated code into multiple files Jun 18, 2024
simonrozsival
simonrozsival previously approved these changes Jun 18, 2024
View reviewed changes
@jonathanpeppers
Copy link
Copy Markdown
Member

jonathanpeppers commented Jun 18, 2024

FYI the changes here were part of:

But we lost them by accident during a rebase.

@jkurdek jkurdek dismissed stale reviews from jonathanpeppers and simonrozsival via bb77840 June 19, 2024 17:30
simonrozsival
simonrozsival previously approved these changes Jun 19, 2024
View reviewed changes
@PureWeen PureWeen added the area-xaml XAML, CSS, Triggers, Behaviors label Jun 20, 2024
@simonrozsival simonrozsival force-pushed the split-generated-code-into-multiple-files branch from bb77840 to 8ae059f Compare June 24, 2024 16:33
@simonrozsival simonrozsival dismissed stale reviews from StephaneDelcroix and themself via caad347 June 24, 2024 20:08
@simonrozsival simonrozsival force-pushed the split-generated-code-into-multiple-files branch from caad347 to 5c535d0 Compare June 25, 2024 10:49
@simonrozsival
Copy link
Copy Markdown
Member

simonrozsival commented Jun 25, 2024 •
edited
Loading

There was a problem with the Essentials.Sample.Server.WebAuthenticator.csproj sample project - the Binding Source Generator was loaded from the .buildtasks directory, and it produced code even though the project didn't reference MAUI at all. I cannot reproduce this with the same project when it is outside of the MAUI repository.

I am not sure if this is due to a presence of Directory.Build.targets or some other implicit behavior of MSBuild, but I don't think this is an issue outside of the MAUI repository. I suppressed the analyzers with an MSBuild property in that particular project for now.

Alternatively, we can change the SG to only generate the common code if the project actually references Microsoft.Maui.Controls.dll. Feedback is welcome.

@simonrozsival simonrozsival changed the title Split bindings source generated code into multiple files [Binding SG] Split bindings source generated code into multiple files Jun 25, 2024
@simonrozsival simonrozsival mentioned this pull request Jul 2, 2024
Closed
26 tasks
@simonrozsival simonrozsival enabled auto-merge (squash) July 2, 2024 16:52
@simonrozsival simonrozsival merged commit c564156 into dotnet:net9.0 Jul 2, 2024
@simonrozsival simonrozsival mentioned this pull request Jul 18, 2024
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 2, 2024
@samhouts samhouts added the fixed-in-net9.0-nightly This may be available in a nightly release! label Aug 2, 2024
@samhouts samhouts added the fixed-in-net8.0-nightly This may be available in a nightly release! label Dec 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jonathanpeppers jonathanpeppers jonathanpeppers approved these changes

@PureWeen PureWeen PureWeen approved these changes

@StephaneDelcroix StephaneDelcroix StephaneDelcroix left review comments

@simonrozsival simonrozsival simonrozsival left review comments

@rmarinho rmarinho Awaiting requested review from rmarinho rmarinho was automatically assigned from dotnet/dotnet-maui-reviewers

Assignees

@simonrozsival simonrozsival

@jkurdek jkurdek

Labels

area-xaml XAML, CSS, Triggers, Behaviors fixed-in-net8.0-nightly This may be available in a nightly release! fixed-in-net9.0-nightly This may be available in a nightly release!

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jkurdek @jonathanpeppers @simonrozsival @StephaneDelcroix @PureWeen @samhouts