[Android] CarouselView: VirtualView cannot be null here, when clearing and adding items on second navigation - fix#22207
Merged
PureWeen merged 12 commits intodotnet:mainfrom May 10, 2024
Merged
Conversation
Contributor
|
Hey there @kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
rmarinho
previously approved these changes
May 6, 2024
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
previously approved these changes
May 7, 2024
| public override string Issue => "[Android] CarouselView: VirtualView cannot be null here, when clearing and adding items on second navigation"; | ||
|
|
||
| [Test] | ||
| public async Task CarouselViewVirtualViewNotNull() |
PureWeen
requested changes
May 7, 2024
|
|
||
| // 2. Tap a Button to load items to the CarouselView. | ||
| App.Tap("TestLoadButton"); | ||
| await Task.Delay(1000); |
Member
There was a problem hiding this comment.
Do you need these delays?
You could probably wait for something in the CarV to load? Attach an AutomationId to the elements inside the CarV and wait for those?
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
rmarinho
previously approved these changes
May 7, 2024
jsuarezruiz
previously approved these changes
May 8, 2024
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
previously approved these changes
May 9, 2024
PureWeen
requested changes
May 10, 2024
src/Controls/src/Core/Handlers/Items/Android/MauiCarouselRecyclerView.cs
Outdated
Show resolved
Hide resolved
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
previously approved these changes
May 10, 2024
mattleibow
previously approved these changes
May 10, 2024
PureWeen
previously approved these changes
May 10, 2024
bc8c905
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
PureWeen
approved these changes
May 10, 2024
|
Good morning, is this adjustment present in version 8.0.5? |
It's in this list for this release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues Fixed
Fixes #22035
Screen.Recording.2024-05-04.at.01.40.31.mov