[Windows] Remove 2nd WebView used to add base tag when using HtmlWebViewSource#21892
Merged
[Windows] Remove 2nd WebView used to add base tag when using HtmlWebViewSource#21892
base tag when using HtmlWebViewSource#21892Conversation
jsuarezruiz
reviewed
Apr 18, 2024
Contributor
jsuarezruiz
left a comment
There was a problem hiding this comment.
LGTM but could we include an UITest loading a local html and validating that everything works comparing a snapshot (for example)?
PureWeen
approved these changes
Apr 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR removes the use of a 2nd "hidden" WebView2 that was used to parse and add a HTML
basetag to theheadtag when setting the HTML source of a WebView to a string.This was done by appending the
basetag script to the start of the user's HTML string, which the WebView then adds into theheadelement. While this is technically not valid HTML, all current browsers correct this behavior.This is a work-around for the lack of being able to set the base URL when navigating to a string using WebView2 (MicrosoftEdge/WebView2Feedback#530).
As a bonus, using
HtmlWebViewSourceshould now be 2x faster 😅Issues Fixed
Fixes #21631