[Android] Fix Ripple Effect in ImageButton#21638
Closed
jsuarezruiz wants to merge 7 commits intomainfrom
Closed
Conversation
jsuarezruiz
commented
Apr 4, 2024
| platformButton.Background = paint?.ToDrawable(platformButton.Context); | ||
| if (paint is not null) | ||
| { | ||
| // TODO: Assign Ids to detect if we already created the RippleDrawable to just |
Contributor
Author
There was a problem hiding this comment.
@PureWeen @mattleibow Different Views are used for Button and ImageButton and they have classes with different extension methods as well. However, the fix may be similar to Button one. Wrap the drawable with the Background with a RippleDrawable that we only create once, and subsequent updates, we modify the one created.
Thoughts?
Contributor
|
Hi, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Fix Ripple Effect in ImageButton.
Issues Fixed
Fixes #18857
Related with #20412 (comment)