[Trimming] Enable trimming and AOT analyzers#21505
Merged
rmarinho merged 5 commits intodotnet:net9.0from Apr 15, 2024
Merged
Conversation
jonathanpeppers
approved these changes
Apr 9, 2024
StephaneDelcroix
approved these changes
Apr 11, 2024
Member
|
@Eilon or someone in @dotnet/dotnet-maui-blazor-eng care to review? This ignores a trimmer warning in WinForms/WPF BlazorWebView, but we filed an issue for the future at: |
Contributor
I'm reviewing. If we take the change in #21797, does this PR need to change at all? (I think the change in #21797 is good, but I want to test locally first) |
Member
|
This PR doesn't need to change if #21797 goes in. The warning suppressed here is around |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR enables trimming, AOT, and single file analyzers to assemblies where it doesn't require any changes. For Essentials.csproj and Compatibility.csproj I changed IsTrimmable to IsAotCompatible.
The only projects that don't have the analyzers enabled yet are:
I'm also skipping adding analyzers to:
Issues Fixed
Contributes to #18658