[Trimming] Disable query property assignment via reflection on NativeAOT#20731
Merged
rmarinho merged 5 commits intodotnet:net9.0from Feb 22, 2024
Merged
Conversation
jonathanpeppers
previously approved these changes
Feb 20, 2024
Member
jonathanpeppers
left a comment
There was a problem hiding this comment.
After toggling whitespace:
This one looks very straightforward, as it just wraps a single chunk of code with if (RuntimeFeature.IsQueryPropertyAttributeSupported).
Co-authored-by: Jonathan Peppers <jonathan.peppers@gmail.com>
rmarinho
approved these changes
Feb 22, 2024
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR fixes 2 trimming warnings in
dotnet new mauiapp.This PR introduces a feature switch that will disable the part of shell navigation that propagates the query parameters to properties based on
[QueryProperty("PropertyName", "queryId")]attributes. The developer can still consume query parameters by implementing theIQueryAttributableinterface manually. The feature will enabled by default for all Mono apps and it will be disabled by default only when building with NativeAOT.Issues Fixed
Contributes to #19397
We could reintroduce this feature for NativeAOT apps if #20466 is approved and implemented.
/cc @PureWeen @mattleibow @jonathanpeppers