Add support for relative binding sources to TypedBinding#20415
Merged
rmarinho merged 3 commits intodotnet:net9.0from Feb 13, 2024
Merged
Add support for relative binding sources to TypedBinding#20415rmarinho merged 3 commits intodotnet:net9.0from
rmarinho merged 3 commits intodotnet:net9.0from
Conversation
2 tasks
Member
|
/rebase |
f085d3c to
d528179
Compare
rmarinho
previously requested changes
Feb 12, 2024
Member
rmarinho
left a comment
There was a problem hiding this comment.
D:\a\_work\1\s\src\Controls\tests\Core.UnitTests\MultiBindingTests.cs(122,7): error CS0103: The name 'TypedBindingFactory' does not exist in the current context [D:\a\_work\1\s\src\Controls\tests\Core.UnitTests\Controls.Core.UnitTests.csproj]
D:\a\_work\1\s\src\Controls\tests\Core.UnitTests\MultiBindingTests.cs(123,7): error CS0103: The name 'TypedBindingFactory' does not exist in the current context [D:\a\_work\1\s\src\Controls\tests\Core.UnitTests\Controls.Core.UnitTests.csproj]
D:\a\_work\1\s\src\Controls\tests\Core.UnitTests\MultiBindingTests.cs(124,7): error CS0103: The name 'TypedBindingFactory' does not exist in the current context [D:\a\_work\1\s\src\Controls\tests\Core.UnitTests\Controls.Core.UnitTests.csproj]
D:\a\_work\1\s\src\Controls\tests\Core.UnitTests\MultiBindingTests.cs(245,9): error CS0103: The name 'TypedBindingFactory' does not exist in the current context [D:\a\_work\1\s\src\Controls\tests\Core.UnitTests\Controls.Core.UnitTests.csproj]
D:\a\_work\1\s\src\Controls\tests\Core.UnitTests\MultiBindingTests.cs(246,9): error CS0103: The name 'TypedBindingFactory' does not exist in the current context [D:\a\_work\1\s\src\Controls\tests\Core.UnitTests\Controls.Core.UnitTests.csproj]
D:\a\_work\1\s\src\Controls\tests\Core.UnitTests\MultiBindingTests.cs(247,9): error CS0103: The name 'TypedBindingFactory' does not exist in the current context [D:\a\_work\1\s\src\Controls\tests\Core.UnitTests\Controls.Core.UnitTests.csproj]
D:\a\_work\1\s\src\Controls\tests\Core.UnitTests\MultiBindingTests.cs(248,9): error CS0103: The name 'TypedBindingFactory' does not exist in the current context [D:\a\_work\1\s\src\Controls\tests\Core.UnitTests\Controls.Core.UnitTests.csproj]
D:\a\_work\1\s\src\Controls\tests\Core.UnitTests\MultiBindingTests.cs(257,7): error CS0103: The name 'TypedBindingFactory' does not exist in the current context [D:\a\_work\1\s\src\Controls\tests\Core.UnitTests\Controls.Core.UnitTests.csproj]
D:\a\_work\1\s\src\Controls\tests\Core.UnitTests\MultiBindingTests.cs(258,7): error CS0103: The name 'TypedBindingFactory' does not exist in the current context [D:\a\_work\1\s\src\Controls\tests\Core.UnitTests\Controls.Core.UnitTests.csproj]
D:\a\_work\1\s\src\Controls\tests\Core.UnitTests\MultiBindingTests.cs(1022,6): error CS1739: The best overload for 'SetBinding' does not have a parameter named 'source' [D:\a\_work\1\s\src\Controls\tests\Core.UnitTests\Controls.Core.UnitTests.csproj]
D:\a\_work\1\s\src\Controls\tests\Core.UnitTests\MultiBindingTests.cs(1026,7): error CS0103: The name 'TypedBindingFactory' does not exist in the current context [D:\a\_work\1\s\src\Controls\tests\Core.UnitTests\Controls.Core.UnitTests.csproj]
D:\a\_work\1\s\src\Controls\tests\Core.UnitTests\MultiBindingTests.cs(1027,7): error CS0103: The name 'TypedBindingFactory' does not exist in the current context [D:\a\_work\1\s\src\Controls\tests\Core.UnitTests\Controls.Core.UnitTests.csproj]
D:\a\_work\1\s\src\Controls\tests\Core.UnitTests\RelativeSourceBindingTests.cs(35,80): error CS1739: The best overload for 'SetBinding' does not have a parameter named 'source' [D:\a\_work\1\s\src\Controls\tests\Core.UnitTests\Controls.Core.UnitTests.csproj]
D:\a\_work\1\s\src\Controls\tests\Core.UnitTests\RelativeSourceBindingTests.cs(69,86): error CS1739: The best overload for 'SetBinding' does not have a parameter named 'source' [D:\a\_work\1\s\src\Controls\tests\Core.UnitTests\Controls.Core.UnitTests.csproj]
D:\a\_work\1\s\src\Controls\tests\Core.UnitTests\RelativeSourceBindingTests.cs(105,81): error CS1739: The best overload for 'SetBinding' does not have a parameter named 'source' [D:\a\_work\1\s\src\Controls\tests\Core.UnitTests\Controls.Core.UnitTests.csproj]
D:\a\_work\1\s\src\Controls\tests\Core.UnitTests\RelativeSourceBindingTests.cs(395,82): error CS1739: The best overload for 'SetBinding' does not have a parameter named 'source' [D:\a\_work\1\s\src\Controls\tests\Core.UnitTests\Controls.Core.UnitTests.csproj]
D:\a\_work\1\s\src\Controls\tests\Core.UnitTests\RelativeSourceBindingTests.cs(396,100): error CS1739: The best overload for 'SetBinding' does not have a parameter named 'source' [D:\a\_work\1\s\src\Controls\tests\Core.UnitTests\Controls.Core.UnitTests.csproj]
D:\a\_work\1\s\src\Controls\tests\Core.UnitTests\RelativeSourceBindingTests.cs(400,82): error CS1739: The best overload for 'SetBinding' does not have a parameter named 'source' [D:\a\_work\1\s\src\Controls\tests\Core.UnitTests\Controls.Core.UnitTests.csproj]
D:\a\_work\1\s\src\Controls\tests\Core.UnitTests\RelativeSourceBindingTests.cs(401,100): error CS1739: The best overload for 'SetBinding' does not have a parameter named 'source' [D:\a\_work\1\s\src\Controls\tests\Core.UnitTests\Controls.Core.UnitTests.csproj]
D:\a\_work\1\s\src\Controls\tests\Core.UnitTests\RelativeSourceBindingTests.cs(405,82): error CS1739: The best overload for 'SetBinding' does not have a parameter named 'source' [D:\a\_work\1\s\src\Controls\tests\Core.UnitTests\Controls.Core.UnitTests.csproj]
D:\a\_work\1\s\src\Controls\tests\Core.UnitTests\RelativeSourceBindingTests.cs(406,94): error CS1739: The best overload for 'SetBinding' does not have a parameter named 'source' [D:\a\_work\1\s\src\Controls\tests\Core.UnitTests\Controls.Core.UnitTests.csproj]
5851 Warning(s)
21 Error(s)
StephaneDelcroix
approved these changes
Feb 13, 2024
This was referenced Feb 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
The TypedBinding class didn't support relative binding sources. I implemented the missing functionality and there is now feature parity between classic Binding and TypedBinding. This will allow us to later compile more bindings in XAML into typed bindings using XamlC.
Issues Fixed
Fixes #20101
/cc @StephaneDelcroix