Make sure we support keyed services in client apps#20014
Merged
mattleibow merged 1 commit intomainfrom Jan 22, 2024
Merged
Conversation
Contributor
|
@BrennanConroy / @halter73 - could one of you have a look at adding this support to .NET MAUI? |
Member
|
I'm heading on vacation for the next two weeks. @benjaminpetit might also be able to help. |
Member
BrennanConroy
left a comment
There was a problem hiding this comment.
Does Maui look for attributes anywhere? There is the FromKeyedServicesAttribute if that's relevant to Maui.
Member
Author
|
Thanks for the review! I added a test for the attributes. All seems to be working. Since maui "service provider" is just a wrapper of the real provider with some extra buttons, no new logic was really written. |
PureWeen
approved these changes
Jan 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
New things in .NET 7 and we can't use it out the box.
Fixes #18992