Merged
Conversation
|
Hey there @symbiogenesis! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
jsuarezruiz
previously approved these changes
Jan 18, 2024
jonathanpeppers
requested changes
Jan 18, 2024
Member
jonathanpeppers
left a comment
There was a problem hiding this comment.
It looks like you wrote a manual benchmark instead of using BenchmarkDotNet.
Can you add a benchmark for this change? and add it to this PR?
https://github.com/dotnet/maui/tree/main/src/Core/tests/Benchmarks/Benchmarks
Then let us know your results before/after. Thanks!
StephaneDelcroix
previously approved these changes
Jan 18, 2024
0109d42
Contributor
Author
|
Before:
After:
|
jonathanpeppers
approved these changes
Jan 18, 2024
Member
jonathanpeppers
left a comment
There was a problem hiding this comment.
Awesome! Thank you!
I will put this on the list for some far future blog post. 😄
mattleibow
approved these changes
Jan 19, 2024
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
This was referenced Jan 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This extension method in Core is referenced in at least 19 places.
With this change, the performance in some cases is orders of magnitude better.
https://dotnetfiddle.net/Anb4rA