[release/8.0.1xx-rc2.1] [X] revert #5611#18262
Merged
rmarinho merged 2 commits intorelease/8.0.1xx-rc2.1from Oct 23, 2023
Merged
[release/8.0.1xx-rc2.1] [X] revert #5611#18262rmarinho merged 2 commits intorelease/8.0.1xx-rc2.1from
rmarinho merged 2 commits intorelease/8.0.1xx-rc2.1from
Conversation
As reported in #17461, OnPlatform simplification cause some issues - while used as a Resource (#17461, unable to unit test for now) - doesn't type convert. On nodes shouldn't be replaced by the Value, but an element node (<On Platform="..." Value="Red" /> should generate <Color x:Key="foo">Red</Color>. right now it only generated "Red" - fixes #17461
mattleibow
approved these changes
Oct 23, 2023
rmarinho
approved these changes
Oct 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #17733 to release/8.0.1xx-rc2.1
/cc @PureWeen @StephaneDelcroix