Generate a more complete splash screen drawable set for Android#10516
Merged
mattleibow merged 6 commits intomainfrom Oct 11, 2022
Merged
Generate a more complete splash screen drawable set for Android#10516mattleibow merged 6 commits intomainfrom
mattleibow merged 6 commits intomainfrom
Conversation
This was referenced Oct 6, 2022
mattleibow
commented
Oct 6, 2022
src/SingleProject/Resizetizer/test/UnitTests/testdata/androidsplash/maui_splash_image_v31.xml
Show resolved
Hide resolved
src/SingleProject/Resizetizer/test/UnitTests/GenerateSplashAndroidResourcesTests.cs
Show resolved
Hide resolved
Vpatel541
approved these changes
Oct 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Currently, the asset generating is just a single file - but to fix the splash on android, we need per-OS-version resources.
Issues Fixed
Screenshots
In the screenshots below, the image is NOT square and is relatively large - yet is not stretched nor filling the entire screen. The Android 12+ images have the toes clipped and this is because the splash is forced into a circle and our image is basically using that.
I do not want to automatically resize the image to fit as this may not be desirable. In most cases it is safer to just make sure the actual visible image is only 2/3 of the square size.
For example, if your image fits into a square of 108x108, then the visible area may be clipped outside the 72x72 region.
BEFORE
AFTER
Pre Android 12 / API 31
Post Android 12 / API 31