Skip to content

GetTypeNameFromCustomNamespace does not cache duplicate results #19944

@sharwell

Description

@sharwell

A recent performance trace ([AB#1938540])(https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1938540) shows 50GB allocations coming from splitting the string used by GetNamedFields in the call to GetTypeByMetadataName. I noticed that GetNamedFields does not keep track of types it has already resolved, so it seems likely to be a significant contributing factor to this performance issue.

yield return (name ?? "", GetTypeName(xmlType, compilation, caches), accessModifier);

Metadata

Metadata

Assignees

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions