Stabilize window size check in Issue2818 test

kubaflo · kubaflo · commit bef57ff151c1 · 2025-08-09T01:09:41.000+02:00
Replaced fixed delay with a polling loop to wait for the window width to stabilize after foregrounding the app. This change reduces test flakiness on platforms where layout size may temporarily change before settling.
diff --git a/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/XFIssue/Issue2818.cs b/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/XFIssue/Issue2818.cs
@@ -1,4 +1,4 @@
-﻿﻿#if TEST_FAILS_ON_WINDOWS && TEST_FAILS_ON_CATALYST
+﻿#if TEST_FAILS_ON_WINDOWS && TEST_FAILS_ON_CATALYST
 // Orientation not supported in Catalyst and Windows
 using NUnit.Framework;
 using UITest.Appium;
@@ -51,7 +51,17 @@ public async Task RootViewSizeDoesntChangeAfterBackground()
 		App.WaitForNoElement("RootLayout");
 		App.ForegroundApp();
 		var newWindowSize = App.WaitForElement("RootLayout");
-		await Task.Delay(2000); // Wait for the app to settle after foregrounding
+
+		// Poll until the width stabilizes. After foregrounding, some platforms (esp. Android/iOS)
+		// may momentarily report an intermediate layout size while the window / flyout re-applies
+		// RTL + orientation constraints. This loop prevents test flakiness by waiting for the
+		// final (restored) size instead of asserting too early
+		int retries = 50;
+		while (newWindowSize.GetRect().Width != windowSize.GetRect().Width && retries-- > 0)
+		{
+			await Task.Delay(100);
+		}
+
 		Assert.That(newWindowSize.GetRect().Width, Is.EqualTo(windowSize.GetRect().Width));
 		Assert.That(newWindowSize.GetRect().Height, Is.EqualTo(windowSize.GetRect().Height));
 	}
