Tentative fix for Android

jonathanpeppers · jonathanpeppers · commit b2947792cbba · 2024-04-23T17:02:37.000-05:00
Context: #18757
diff --git a/src/Controls/src/Core/Compatibility/Handlers/ListView/Android/ListViewRenderer.cs b/src/Controls/src/Core/Compatibility/Handlers/ListView/Android/ListViewRenderer.cs
@@ -1,6 +1,7 @@
 #nullable disable
 using System;
 using System.ComponentModel;
+using System.Threading.Tasks;
 using Android.Content;
 using Android.Runtime;
 using Android.Views;
@@ -476,19 +477,17 @@ void UpdateIsRefreshing(bool isInitialValue = false)
 			}
 		}
 
-		void UpdateIsSwipeToRefreshEnabled()
+		async void UpdateIsSwipeToRefreshEnabled()
 		{
 			if (_refresh != null)
 			{
 				var isEnabled = Element.IsPullToRefreshEnabled && (Element as IListViewController).RefreshAllowed;
-				_refresh.Post(() =>
-				{
-					// NOTE: only disable while NOT refreshing, otherwise Command bindings CanExecute behavior will effectively
-					// cancel refresh animation. If not possible right now we will be called by UpdateIsRefreshing().
-					// For details see https://github.com/xamarin/Xamarin.Forms/issues/8384
-					if (isEnabled || !_refresh.Refreshing)
-						_refresh.Enabled = isEnabled;
-				});
+				await Task.Yield();
+				// NOTE: only disable while NOT refreshing, otherwise Command bindings CanExecute behavior will effectively
+				// cancel refresh animation. If not possible right now we will be called by UpdateIsRefreshing().
+				// For details see https://github.com/xamarin/Xamarin.Forms/issues/8384
+				if (isEnabled || !_refresh.Refreshing)
+					_refresh.Enabled = isEnabled;
 			}
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,7 @@`
`1`	`1`	`#nullable disable`
`2`	`2`	`using System;`
`3`	`3`	`using System.ComponentModel;`
	`4`	`+using System.Threading.Tasks;`
`4`	`5`	`using Android.Content;`
`5`	`6`	`using Android.Runtime;`
`6`	`7`	`using Android.Views;`
`@@ -476,19 +477,17 @@ void UpdateIsRefreshing(bool isInitialValue = false)`
`476`	`477`	`}`
`477`	`478`	`}`
`478`	`479`
`479`		`- void UpdateIsSwipeToRefreshEnabled()`
	`480`	`+ async void UpdateIsSwipeToRefreshEnabled()`
`480`	`481`	`{`
`481`	`482`	`if (_refresh != null)`
`482`	`483`	`{`
`483`	`484`	`var isEnabled = Element.IsPullToRefreshEnabled && (Element as IListViewController).RefreshAllowed;`
`484`		`- _refresh.Post(() =>`
`485`		`- {`
`486`		`- // NOTE: only disable while NOT refreshing, otherwise Command bindings CanExecute behavior will effectively`
`487`		`- // cancel refresh animation. If not possible right now we will be called by UpdateIsRefreshing().`
`488`		`- // For details see https://github.com/xamarin/Xamarin.Forms/issues/8384`
`489`		`- if (isEnabled \|\| !_refresh.Refreshing)`
`490`		`- _refresh.Enabled = isEnabled;`
`491`		`- });`
	`485`	`+ await Task.Yield();`
	`486`	`+ // NOTE: only disable while NOT refreshing, otherwise Command bindings CanExecute behavior will effectively`
	`487`	`+ // cancel refresh animation. If not possible right now we will be called by UpdateIsRefreshing().`
	`488`	`+ // For details see https://github.com/xamarin/Xamarin.Forms/issues/8384`
	`489`	`+ if (isEnabled \|\| !_refresh.Refreshing)`
	`490`	`+ _refresh.Enabled = isEnabled;`
`492`	`491`	`}`
`493`	`492`	`}`
`494`	`493`