Address round 3 review comments

mattleibow · Copilot · mattleibow · commit aa6fa0f02e20 · 2026-03-31T17:42:41.000+02:00
- Add CancelPendingSearch to LandmarksViewModel, called from
  OnDisappearing to dispose the debounce timer and cancel any
  in-flight search when navigating away
- Fix TaggingService tag parsing: drop the SelectMany space-split
  that fragmented multi-word hashtags; instead treat each
  comma/newline-separated item as a single tag and reject entries
  with whitespace
- Use Background instead of BackgroundColor on LandmarkListItemView
  and LandmarkFeaturedItemView for consistency with the rest of the
  BackgroundColor-to-Background migration
- Fix WorkflowModels comment to match actual JSON property names
  (place/days/language not dest/days/lang)

Co-authored-by: Copilot &lt;223556219+Copilot@users.noreply.github.com&gt;
diff --git a/src/AI/samples/Essentials.AI.Sample/AI/WorkflowModels.cs b/src/AI/samples/Essentials.AI.Sample/AI/WorkflowModels.cs
@@ -5,7 +5,7 @@ namespace Maui.Controls.Sample.AI;
 
 /// <summary>
 /// Result from the Travel Planner Agent - raw extraction of user intent.
-/// Short JSON names (dest/days/lang) prevent misspelling by small language models.
+/// Short JSON names (place/days/language) reduce misspelling by small language models.
 /// </summary>
 public record TravelPlanResult(
 	[property: JsonPropertyName("place")]
diff --git a/src/AI/samples/Essentials.AI.Sample/Pages/LandmarksPage.xaml.cs b/src/AI/samples/Essentials.AI.Sample/Pages/LandmarksPage.xaml.cs
@@ -53,6 +53,7 @@ protected override void OnAppearing()
 
 	protected override void OnDisappearing()
 	{
+		_viewModel.CancelPendingSearch();
 		_chatViewModel.ChatService.NavigateToTripRequested -= OnNavigateToTrip;
 		base.OnDisappearing();
 	}
diff --git a/src/AI/samples/Essentials.AI.Sample/Services/TaggingService.cs b/src/AI/samples/Essentials.AI.Sample/Services/TaggingService.cs
@@ -36,9 +36,8 @@ Return ONLY a comma-separated list of 5 hashtags. No explanations.
 
 		return responseText
 			.Split([',', '\n', '\r'], StringSplitOptions.RemoveEmptyEntries | StringSplitOptions.TrimEntries)
-			.SelectMany(tag => tag.Split(' ', StringSplitOptions.RemoveEmptyEntries))
-			.Select(tag => tag.TrimStart('#', '-', '•').Trim())
-			.Where(tag => tag.Length > 1 && !tag.Contains(' ', StringComparison.Ordinal))
+			.Select(tag => tag.TrimStart('#', '-', '•', '*').Trim())
+			.Where(tag => tag.Length > 1 && !tag.Any(char.IsWhiteSpace))
 			.Distinct()
 			.Take(5)
 			.ToList();
diff --git a/src/AI/samples/Essentials.AI.Sample/ViewModels/LandmarksViewModel.cs b/src/AI/samples/Essentials.AI.Sample/ViewModels/LandmarksViewModel.cs
@@ -40,6 +40,13 @@ public partial class LandmarksViewModel(
 	/// <summary>All continent groups (unfiltered).</summary>
 	List<ContinentGroup> _allGroups = [];
 
+	public void CancelPendingSearch()
+	{
+		_debounceTimer?.Dispose();
+		_debounceTimer = null;
+		_searchCts?.Cancel();
+	}
+
 	public ObservableCollection<ContinentGroup> ContinentGroups => field ??= [];
 
 	partial void OnSearchQueryChanged(string? value)
diff --git a/src/AI/samples/Essentials.AI.Sample/Views/Landmarks/LandmarkFeaturedItemView.xaml b/src/AI/samples/Essentials.AI.Sample/Views/Landmarks/LandmarkFeaturedItemView.xaml
@@ -10,7 +10,7 @@
         Padding="0"
         StrokeShape="RoundRectangle 16"
         StrokeThickness="0"
-        BackgroundColor="Transparent"
+        Background="Transparent"
         Shadow="{Shadow Brush=Black, Offset='0,2', Radius=8, Opacity=0.3}">
         <Border.GestureRecognizers>
             <TapGestureRecognizer Tapped="OnFeaturedLandmarkTapped" />
diff --git a/src/AI/samples/Essentials.AI.Sample/Views/Landmarks/LandmarkListItemView.xaml b/src/AI/samples/Essentials.AI.Sample/Views/Landmarks/LandmarkListItemView.xaml
@@ -12,7 +12,7 @@
         Padding="0"
         StrokeShape="RoundRectangle 16"
         StrokeThickness="0"
-        BackgroundColor="Transparent"
+        Background="Transparent"
         Shadow="{Shadow Brush=Black, Offset='0,2', Radius=8, Opacity=0.3}">
         <Border.GestureRecognizers>
             <TapGestureRecognizer Tapped="OnLandmarkTapped" />

Original file line number	Diff line number	Diff line change
`@@ -53,6 +53,7 @@ protected override void OnAppearing()`
`53`	`53`
`54`	`54`	`protected override void OnDisappearing()`
`55`	`55`	`{`
	`56`	`+ _viewModel.CancelPendingSearch();`
`56`	`57`	`_chatViewModel.ChatService.NavigateToTripRequested -= OnNavigateToTrip;`
`57`	`58`	`base.OnDisappearing();`
`58`	`59`	`}`