Skip to content

[apidiff] Update XML references with 15.8 as the new base#4671

Merged
spouliot merged 2 commits intodotnet:d15-9from
spouliot:d15-9-apidiff-update
Aug 24, 2018
Merged

[apidiff] Update XML references with 15.8 as the new base#4671
spouliot merged 2 commits intodotnet:d15-9from
spouliot:d15-9-apidiff-update

Conversation

@spouliot
Copy link
Contributor

No description provided.

@spouliot spouliot added this to the d15-9 milestone Aug 21, 2018
@monojenkins
Copy link
Contributor

Build success
Build succeeded
API Diff (from stable)
ℹ️ API Diff (from PR only) (please review changes)
Generator Diff (only version changes)
Test run succeeded

Copy link
Member

@rolfbjarne rolfbjarne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The XM diff shows a lot of:

Added interface:

	Runtime.InteropServices._Exception

is that something we can fix somehow?

@spouliot
Copy link
Contributor Author

@rolfbjarne XM should be identical to XI results. I think this happened because we update XI more often (Xcode* branches) so that change was done for XI earlier. I'll look at the filtering options the tool has

@rolfbjarne
Copy link
Member

@spouliot you're updating the XM reference files, but the api diff done by the bot still lists those differences. If the api diff should ever be empty, it should be when we're updating the reference files...

This feels like one of those differences we had in the past when we were getting differences because of different mono versions used to generate the references vs when creating the api diff.

@spouliot
Copy link
Contributor Author

@rolfbjarne the same mono was used to create references for both XI and XM in the PR. If the XML differs then it's because the assemblies also differ

@spouliot
Copy link
Contributor Author

I can reduce the diff size, removing assemblies with only those change, to help readability. Hand editing I'll avoid :)

@spouliot spouliot added the skip-all-tests Skip all the tests label Aug 24, 2018
@monojenkins
Copy link
Contributor

@spouliot spouliot merged commit 7ea465f into dotnet:d15-9 Aug 24, 2018
@spouliot spouliot deleted the d15-9-apidiff-update branch August 24, 2018 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-all-tests Skip all the tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants