[tests] Migrate Cecil tests to NUnit v4. by rolfbjarne · Pull Request #24525 · dotnet/macios

rolfbjarne · 2026-01-19T11:54:39Z

No description provided.

Copilot

Pull request overview

This PR migrates the Cecil test suite from NUnit v3 to NUnit v4, updating package references and converting assertion syntax to be compatible with the newer version.

Changes:

Updated NUnit and related test package versions in Directory.Build.props
Replaced hardcoded package versions with centralized version variables in cecil-tests.csproj
Converted legacy NUnit assertion syntax to constraint model (e.g., Assert.False → Assert.That(..., Is.False))

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
Directory.Build.props	Defines centralized version variables for NUnit v4 packages and test SDK
tests/cecil-tests/cecil-tests.csproj	Replaces hardcoded package versions with centralized variables
tests/cecil-tests/Test.cs	Updates assertion syntax from legacy to constraint model
tests/cecil-tests/Helper.cs	Updates assertion syntax and adds null-coalescing operator for null safety
tests/cecil-tests/GetterExceptionTest.cs	Converts `Assert.AreEqual` to constraint model
tests/cecil-tests/GenericPInvokes.cs	Converts assertions to constraint model
tests/cecil-tests/BlittablePInvokes.cs	Converts `Assert.IsNotNull` to constraint model
tests/cecil-tests/ApiCapitalizationTest.cs	Converts `Assert.AreEqual` to constraint model
tests/cecil-tests/ApiAvailabilityTest.cs	Converts `Assert.AreEqual` to constraint model

Copilot · 2026-01-19T12:04:48Z

tests/cecil-tests/GenericPInvokes.cs

 			var assembly = info.Assembly;
 			var pinvokes = AllPInvokes (assembly).Where (IsPInvokeOK);
-			Assert.IsTrue (pinvokes.Count () > 0);
+			Assert.That (pinvokes.Count, Is.GreaterThan (0), Is.True);


The third argument Is.True appears to be incorrectly used. The constraint Is.GreaterThan(0) already expresses the assertion; adding Is.True is unnecessary and likely invalid syntax. Remove the Is.True parameter.

Suggested change

Assert.That (pinvokes.Count, Is.GreaterThan (0), Is.True);

Assert.That (pinvokes.Count, Is.GreaterThan (0));

Copilot · 2026-01-19T12:04:48Z

tests/cecil-tests/GenericPInvokes.cs

 			var assembly = info.Assembly;
 			var pinvokes = AllPInvokes (assembly).Where (IsPInvokeOK);
-			Assert.IsTrue (pinvokes.Count () > 0);
+			Assert.That (pinvokes.Count, Is.GreaterThan (0), Is.True);


Using Count property instead of Count() method would be more appropriate if pinvokes is an ICollection or IList. If it's an IEnumerable, the call is correct, but the type should be clarified for consistency with line 38-39.

Suggested change

Assert.That (pinvokes.Count, Is.GreaterThan (0), Is.True);

Assert.That (pinvokes.Count (), Is.GreaterThan (0), Is.True);

vs-mobiletools-engineering-service2 · 2026-01-19T17:52:02Z

✅ [PR Build #d66dfd3] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: d66dfd3a692a5b6f02a60c39698f87a767399a1a [PR build]

vs-mobiletools-engineering-service2 · 2026-01-19T18:11:08Z

✅ [CI Build #d66dfd3] Build passed (Build packages) ✅

Pipeline on Agent
Hash: d66dfd3a692a5b6f02a60c39698f87a767399a1a [PR build]

vs-mobiletools-engineering-service2 · 2026-01-19T18:18:31Z

✅ API diff for current PR / commit

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

✅ API diff vs stable

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: d66dfd3a692a5b6f02a60c39698f87a767399a1a [PR build]

vs-mobiletools-engineering-service2 · 2026-01-19T18:47:24Z

✅ [CI Build #d66dfd3] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: d66dfd3a692a5b6f02a60c39698f87a767399a1a [PR build]

vs-mobiletools-engineering-service2 · 2026-01-19T18:58:24Z

💻 [CI Build #d66dfd3] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: d66dfd3a692a5b6f02a60c39698f87a767399a1a [PR build]

vs-mobiletools-engineering-service2 · 2026-01-19T19:00:05Z

💻 [CI Build #d66dfd3] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: d66dfd3a692a5b6f02a60c39698f87a767399a1a [PR build]

vs-mobiletools-engineering-service2 · 2026-01-19T19:01:06Z

💻 [CI Build #d66dfd3] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: d66dfd3a692a5b6f02a60c39698f87a767399a1a [PR build]

vs-mobiletools-engineering-service2 · 2026-01-19T19:02:49Z

💻 [CI Build #d66dfd3] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

✅ All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: d66dfd3a692a5b6f02a60c39698f87a767399a1a [PR build]

vs-mobiletools-engineering-service2 · 2026-01-20T08:31:02Z

💻 [CI Build #d66dfd3] Tests on macOS arm64 - Mac Tahoe (26) passed 💻

✅ All tests on macOS arm64 - Mac Tahoe (26) passed.

Pipeline on Agent
Hash: d66dfd3a692a5b6f02a60c39698f87a767399a1a [PR build]

vs-mobiletools-engineering-service2 · 2026-01-20T09:14:42Z

🚀 [CI Build #d66dfd3] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 125 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 15 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 11 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: d66dfd3a692a5b6f02a60c39698f87a767399a1a [PR build]

[tests] Migrate Cecil tests to NUnit v4.

20050cb

rolfbjarne requested a review from Copilot January 19, 2026 11:54

Copilot started reviewing on behalf of rolfbjarne January 19, 2026 11:55 View session

Copilot AI reviewed Jan 19, 2026

View reviewed changes

This comment has been minimized.

Sign in to view

tweaks

d66dfd3

rolfbjarne enabled auto-merge (squash) January 19, 2026 17:22

This comment has been minimized.

Sign in to view

dalexsoto approved these changes Jan 20, 2026

View reviewed changes

rolfbjarne merged commit 1d5c873 into main Jan 20, 2026
45 checks passed

rolfbjarne added the copilot label Feb 2, 2026

	Assert.That (pinvokes.Count, Is.GreaterThan (0), Is.True);
	Assert.That (pinvokes.Count, Is.GreaterThan (0));

	Assert.That (pinvokes.Count, Is.GreaterThan (0), Is.True);
	Assert.That (pinvokes.Count (), Is.GreaterThan (0), Is.True);

Conversation

rolfbjarne commented Jan 19, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 19, 2026

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Jan 19, 2026

✅ [PR Build #d66dfd3] Build passed (Detect API changes) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Jan 19, 2026

✅ [CI Build #d66dfd3] Build passed (Build packages) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Jan 19, 2026

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

Uh oh!

vs-mobiletools-engineering-service2 commented Jan 19, 2026

✅ [CI Build #d66dfd3] Build passed (Build macOS tests) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Jan 19, 2026

💻 [CI Build #d66dfd3] Tests on macOS X64 - Mac Sonoma (14) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Jan 19, 2026

💻 [CI Build #d66dfd3] Tests on macOS M1 - Mac Monterey (12) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Jan 19, 2026

💻 [CI Build #d66dfd3] Tests on macOS M1 - Mac Ventura (13) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Jan 19, 2026

💻 [CI Build #d66dfd3] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

Uh oh!

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Jan 20, 2026

💻 [CI Build #d66dfd3] Tests on macOS arm64 - Mac Tahoe (26) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Jan 20, 2026

🚀 [CI Build #d66dfd3] Test results 🚀

Test results

Tests counts

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants