[msbuild] Simplify DetectSdkLocation to not detect whether we're building for the simulator or not.#24514
Conversation
…ding for the simulator or not. We already know if we're building for the simulator or not when calling the DetectSdkLocation task, so just tell it.
There was a problem hiding this comment.
Pull request overview
This PR simplifies the DetectSdkLocation MSBuild task by removing the logic that detects whether a build is for a simulator or device. Instead, the task now receives SdkIsSimulator as an input parameter since this information is already known from the runtime identifier earlier in the build process.
Changes:
- Removed internal simulator detection logic from
DetectSdkLocationtask that parsedTargetArchitecturesandIsDotNetSimulatorBuild - Changed
SdkIsSimulatorfrom an output parameter to a required input parameter - Removed obsolete
_IsDotNetSimulatorBuildproperty group that was redundant withSdkIsSimulator
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| msbuild/Xamarin.MacDev.Tasks/Tasks/DetectSdkLocation.cs | Converted SdkIsSimulator from output to required input, removed SetIsSimulator() method and unused TargetArchitectures/IsDotNetSimulatorBuild inputs |
| msbuild/Xamarin.Shared/Xamarin.Shared.targets | Removed TargetArchitectures and IsDotNetSimulatorBuild inputs to DetectSdkLocations task, changed to pass SdkIsSimulator as input instead of receiving it as output |
| dotnet/targets/Xamarin.Shared.Sdk.DefaultItems.targets | Removed obsolete _IsDotNetSimulatorBuild property group and updated ComputedPlatform to use SdkIsSimulator directly |
✅ [CI Build #9afb67c] Build passed (Build packages) ✅Pipeline on Agent |
✅ [PR Build #9afb67c] Build passed (Detect API changes) ✅Pipeline on Agent |
✅ [CI Build #9afb67c] Build passed (Build macOS tests) ✅Pipeline on Agent |
💻 [CI Build #9afb67c] Tests on macOS X64 - Mac Sonoma (14) passed 💻✅ All tests on macOS X64 - Mac Sonoma (14) passed. Pipeline on Agent |
💻 [CI Build #9afb67c] Tests on macOS M1 - Mac Monterey (12) passed 💻✅ All tests on macOS M1 - Mac Monterey (12) passed. Pipeline on Agent |
💻 [CI Build #9afb67c] Tests on macOS M1 - Mac Ventura (13) passed 💻✅ All tests on macOS M1 - Mac Ventura (13) passed. Pipeline on Agent |
💻 [CI Build #9afb67c] Tests on macOS arm64 - Mac Sequoia (15) passed 💻✅ All tests on macOS arm64 - Mac Sequoia (15) passed. Pipeline on Agent |
💻 [CI Build #9afb67c] Tests on macOS arm64 - Mac Tahoe (26) passed 💻✅ All tests on macOS arm64 - Mac Tahoe (26) passed. Pipeline on Agent |
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
🚀 [CI Build #9afb67c] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 117 tests passed 🎉 Tests counts✅ cecil: All 1 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
We already know if we're building for the simulator or not when calling the
DetectSdkLocation task, so just tell it.