Skip to content

[src] Fix make quietness inside templates.#24505

Merged
rolfbjarne merged 1 commit intomainfrom
dev/rolf/src-quiet
Jan 14, 2026
Merged

[src] Fix make quietness inside templates.#24505
rolfbjarne merged 1 commit intomainfrom
dev/rolf/src-quiet

Conversation

@rolfbjarne
Copy link
Member

No description provided.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request fixes Make quietness variable escaping in the BuildDotNetIntermediateAssembly template in src/Makefile. When Make templates use variables like $(Q) and $(Q_GEN) to control build output verbosity, these need to be escaped as $$(Q) and $$(Q_GEN) so they are evaluated at template expansion time rather than definition time.

Changes:

  • Fixed four instances where quietness variables were using single dollar sign syntax instead of the required double dollar sign syntax for template variables
  • All changes are within the BuildDotNetIntermediateAssembly template definition

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [CI Build #0831d17] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 0831d170ecf748826888ee7c9b4bbf2ec19df7f4 [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [CI Build #0831d17] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 0831d170ecf748826888ee7c9b4bbf2ec19df7f4 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #0831d17] Tests on macOS X64 - Mac Sonoma (14) passed 💻

All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 0831d170ecf748826888ee7c9b4bbf2ec19df7f4 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #0831d17] Tests on macOS M1 - Mac Monterey (12) passed 💻

All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 0831d170ecf748826888ee7c9b4bbf2ec19df7f4 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #0831d17] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: 0831d170ecf748826888ee7c9b4bbf2ec19df7f4 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #0831d17] Tests on macOS M1 - Mac Ventura (13) passed 💻

All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 0831d170ecf748826888ee7c9b4bbf2ec19df7f4 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #0831d17] Tests on macOS arm64 - Mac Tahoe (26) passed 💻

All tests on macOS arm64 - Mac Tahoe (26) passed.

Pipeline on Agent
Hash: 0831d170ecf748826888ee7c9b4bbf2ec19df7f4 [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [PR Build #0831d17] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 0831d170ecf748826888ee7c9b4bbf2ec19df7f4 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ API diff for current PR / commit

NET (empty diffs)

✅ API diff vs stable

NET (empty diffs)

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 0831d170ecf748826888ee7c9b4bbf2ec19df7f4 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🚀 [CI Build #0831d17] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 119 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 11 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 9 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 0831d170ecf748826888ee7c9b4bbf2ec19df7f4 [PR build]

@rolfbjarne rolfbjarne merged commit ae6a664 into main Jan 14, 2026
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants