[SceneKit] Distribute nullability for a few properties.#24496
[SceneKit] Distribute nullability for a few properties.#24496rolfbjarne merged 1 commit intomainfrom
Conversation
If a property wraps another nullable property, the wrapping property should also be nullable.
There was a problem hiding this comment.
Pull request overview
This PR adds [NullAllowed] attributes to wrapper properties in the SceneKit bindings to ensure nullability is correctly propagated from the underlying Contents property.
Changes:
- Added
[NullAllowed]attribute to 8 wrapper properties that wrap the nullableContentsproperty inSCNMaterialProperty
✅ [CI Build #8fe6ece] Build passed (Build packages) ✅Pipeline on Agent |
✅ [PR Build #8fe6ece] Build passed (Detect API changes) ✅Pipeline on Agent |
✅ [CI Build #8fe6ece] Build passed (Build macOS tests) ✅Pipeline on Agent |
💻 [CI Build #8fe6ece] Tests on macOS X64 - Mac Sonoma (14) passed 💻✅ All tests on macOS X64 - Mac Sonoma (14) passed. Pipeline on Agent |
💻 [CI Build #8fe6ece] Tests on macOS M1 - Mac Monterey (12) passed 💻✅ All tests on macOS M1 - Mac Monterey (12) passed. Pipeline on Agent |
💻 [CI Build #8fe6ece] Tests on macOS arm64 - Mac Sequoia (15) passed 💻✅ All tests on macOS arm64 - Mac Sequoia (15) passed. Pipeline on Agent |
💻 [CI Build #8fe6ece] Tests on macOS M1 - Mac Ventura (13) passed 💻✅ All tests on macOS M1 - Mac Ventura (13) passed. Pipeline on Agent |
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
💻 [CI Build #8fe6ece] Tests on macOS arm64 - Mac Tahoe (26) passed 💻✅ All tests on macOS arm64 - Mac Tahoe (26) passed. Pipeline on Agent |
🚀 [CI Build #8fe6ece] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 117 tests passed 🎉 Tests counts✅ cecil: All 1 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
If a property wraps another nullable property, the wrapping property should also
be nullable.