[tests] Use existing 'SecIdentity.Import' API instead of manually trying to do the same thing. by rolfbjarne · Pull Request #24432 · dotnet/macios

rolfbjarne · 2025-12-12T15:41:31Z

Hopefully fixes:

MonoTouchFixtures.CoreWlan.CWKeychainTests
	[FAIL] TrySetWiFiEAPIdentityTest :   ImportPkcs12
  Expected: Success
  But was:  DuplicateItem
		   at MonoTouchFixtures.Security.IdentityTest.GetIdentity() in /Users/builder/azdo/_work/1/s/macios/tests/monotouch-test/Security/IdentityTest.cs:line 25
		   at MonoTouchFixtures.CoreWlan.CWKeychainTests.TrySetWiFiEAPIdentityTest() in /Users/builder/azdo/_work/1/s/macios/tests/monotouch-test/CoreWlan/CWKeychainTests.cs:line 94

Because 'SecImportExport.ImportPkcs12' will by default on macOS import into an
existing keychain (and is thus subject to 'DuplicateItem' problems); while
'SecIdentity.Import' will try to avoid using an existing keychain if
possible (which it is on macOS 15+, or all other platforms).

…ing to do the same thing. Hopefully fixes: MonoTouchFixtures.CoreWlan.CWKeychainTests [FAIL] TrySetWiFiEAPIdentityTest : ImportPkcs12 Expected: Success But was: DuplicateItem at MonoTouchFixtures.Security.IdentityTest.GetIdentity() in /Users/builder/azdo/_work/1/s/macios/tests/monotouch-test/Security/IdentityTest.cs:line 25 at MonoTouchFixtures.CoreWlan.CWKeychainTests.TrySetWiFiEAPIdentityTest() in /Users/builder/azdo/_work/1/s/macios/tests/monotouch-test/CoreWlan/CWKeychainTests.cs:line 94 Because 'SecImportExport.ImportPkcs12' will by default on macOS import into an existing keychain (and is thus subject to 'DuplicateItem' problems); while 'SecIdentity.Import' will try to avoid using an existing keychain if possible (which it is on macOS 15+, or all other platforms).

Copilot

Pull request overview

This PR simplifies test code for creating a SecIdentity instance by replacing manual SecImportExport.ImportPkcs12 calls with the higher-level SecIdentity.Import API. This change addresses test flakiness caused by DuplicateItem errors on macOS, where SecImportExport.ImportPkcs12 imports into the default keychain by default, leading to duplicate entries across test runs.

Key Changes:

Replaced 6 lines of manual PKCS#12 import code with a single call to SecIdentity.Import
Eliminates explicit NSDictionary/NSString setup and error handling from test helper method
Leverages SecIdentity.Import's built-in platform handling (uses in-memory keychain on macOS 15+)

vs-mobiletools-engineering-service2 · 2026-01-14T11:55:19Z

✅ [CI Build #8e53f39] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 8e53f39fd8a39661525e13cd79679cbadef8b4e6 [PR build]

vs-mobiletools-engineering-service2 · 2026-01-14T11:57:55Z

✅ [PR Build #8e53f39] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 8e53f39fd8a39661525e13cd79679cbadef8b4e6 [PR build]

vs-mobiletools-engineering-service2 · 2026-01-14T12:24:03Z

✅ API diff for current PR / commit

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

✅ API diff vs stable

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 8e53f39fd8a39661525e13cd79679cbadef8b4e6 [PR build]

vs-mobiletools-engineering-service2 · 2026-01-14T12:29:37Z

✅ [CI Build #8e53f39] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 8e53f39fd8a39661525e13cd79679cbadef8b4e6 [PR build]

vs-mobiletools-engineering-service2 · 2026-01-14T12:38:49Z

💻 [CI Build #8e53f39] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 8e53f39fd8a39661525e13cd79679cbadef8b4e6 [PR build]

vs-mobiletools-engineering-service2 · 2026-01-14T12:42:14Z

💻 [CI Build #8e53f39] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 8e53f39fd8a39661525e13cd79679cbadef8b4e6 [PR build]

vs-mobiletools-engineering-service2 · 2026-01-14T12:43:43Z

💻 [CI Build #8e53f39] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

✅ All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: 8e53f39fd8a39661525e13cd79679cbadef8b4e6 [PR build]

vs-mobiletools-engineering-service2 · 2026-01-14T12:43:52Z

💻 [CI Build #8e53f39] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 8e53f39fd8a39661525e13cd79679cbadef8b4e6 [PR build]

vs-mobiletools-engineering-service2 · 2026-01-14T18:33:46Z

💻 [CI Build #8e53f39] Tests on macOS arm64 - Mac Tahoe (26) passed 💻

✅ All tests on macOS arm64 - Mac Tahoe (26) passed.

Pipeline on Agent
Hash: 8e53f39fd8a39661525e13cd79679cbadef8b4e6 [PR build]

vs-mobiletools-engineering-service2 · 2026-01-14T19:48:12Z

🚀 [CI Build #8e53f39] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 117 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ monotouch (iOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 9 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 8e53f39fd8a39661525e13cd79679cbadef8b4e6 [PR build]

rolfbjarne enabled auto-merge (squash) December 12, 2025 15:41

rolfbjarne requested a review from Copilot December 12, 2025 15:41

Copilot started reviewing on behalf of rolfbjarne December 12, 2025 15:42 View session

Copilot AI reviewed Dec 12, 2025

View reviewed changes