[Foundation] Fix nullability in NSMutableSet<TKey>. by rolfbjarne · Pull Request #24422 · dotnet/macios

rolfbjarne · 2025-12-11T14:40:15Z

This is file 32 of 47 files with nullability disabled in Foundation.

Changes:

Enabled nullable reference types
Removed four [SupportedOSPlatform] attributes without version numbers
Removed 'To be added' placeholder comments
Added comprehensive XML documentation for all public members
Added class-level documentation with typeparam
Made LookupMember and AnyObject return nullable since they can return null
Made operator parameters nullable to match actual usage patterns
Made subtraction operator return type nullable since it returns null for empty/null first operand
Added see cref attributes for better documentation
Improved formatting and consistency of XML comments
Add more tests.

Contributes towards #17285.

This is file 32 of 47 files with nullability disabled in Foundation. Changes: * Enabled nullable reference types * Removed four [SupportedOSPlatform] attributes without version numbers * Removed 'To be added' placeholder comments * Added comprehensive XML documentation for all public members * Added class-level documentation with typeparam * Made LookupMember and AnyObject return nullable since they can return null * Made operator parameters nullable to match actual usage patterns * Made subtraction operator return type nullable since it returns null for empty/null first operand * Added see cref attributes for better documentation * Improved formatting and consistency of XML comments * Add more tests. Contributes towards #17285.

Copilot

Pull request overview

This pull request enables nullable reference types in NSMutableSet<TKey> as part of the ongoing effort to add nullability annotations across the Foundation namespace (file 32 of 47). The PR modernizes the code by replacing placeholder documentation with comprehensive XML comments and makes appropriate nullability adjustments to method return types and operator signatures.

Key Changes

Enabled #nullable enable and updated method/property signatures to use nullable return types where appropriate (LookupMember, AnyObject, and operators)
Added detailed XML documentation for all public members, replacing "To be added" placeholders with clear descriptions
Made operator + and - accept and return nullable types to properly handle null set scenarios
Added 17 comprehensive unit tests covering edge cases including null sets, empty sets, overlapping sets, and various operator behaviors

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
src/Foundation/NSMutableSet_1.cs	Enabled nullable reference types, updated return types for `LookupMember` and `AnyObject` to be nullable, made operator parameters/return types nullable, and added comprehensive XML documentation for all public members
tests/monotouch-test/Foundation/NSMutableSet1Test.cs	Added 17 new test methods covering operator behavior with null/empty sets, edge cases for Add/Remove/Contains/LookupMember, array conversion, enumeration, and constructor variations
tests/cecil-tests/Documentation.KnownFailures.txt	Removed two entries for `NSMutableSet<TKey>` operators now that they have proper documentation

src/Foundation/NSMutableSet_1.cs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

vs-mobiletools-engineering-service2 · 2025-12-12T11:45:48Z

✅ [CI Build #8522f4d] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 8522f4d54ed82515c827516d9b49e71a0c2c15d0 [PR build]

vs-mobiletools-engineering-service2 · 2025-12-12T11:47:48Z

✅ [PR Build #8522f4d] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 8522f4d54ed82515c827516d9b49e71a0c2c15d0 [PR build]

vs-mobiletools-engineering-service2 · 2025-12-12T12:14:27Z

✅ API diff for current PR / commit

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

✅ API diff vs stable

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 8522f4d54ed82515c827516d9b49e71a0c2c15d0 [PR build]

vs-mobiletools-engineering-service2 · 2025-12-12T12:20:17Z

✅ [CI Build #8522f4d] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 8522f4d54ed82515c827516d9b49e71a0c2c15d0 [PR build]

vs-mobiletools-engineering-service2 · 2025-12-12T12:29:22Z

💻 [CI Build #8522f4d] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 8522f4d54ed82515c827516d9b49e71a0c2c15d0 [PR build]

vs-mobiletools-engineering-service2 · 2025-12-12T12:33:48Z

💻 [CI Build #8522f4d] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 8522f4d54ed82515c827516d9b49e71a0c2c15d0 [PR build]

vs-mobiletools-engineering-service2 · 2025-12-12T12:33:51Z

💻 [CI Build #8522f4d] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 8522f4d54ed82515c827516d9b49e71a0c2c15d0 [PR build]

vs-mobiletools-engineering-service2 · 2025-12-12T12:36:41Z

💻 [CI Build #8522f4d] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

✅ All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: 8522f4d54ed82515c827516d9b49e71a0c2c15d0 [PR build]

vs-mobiletools-engineering-service2 · 2025-12-12T12:38:29Z

💻 [CI Build #8522f4d] Tests on macOS arm64 - Mac Tahoe (26) passed 💻

✅ All tests on macOS arm64 - Mac Tahoe (26) passed.

Pipeline on Agent
Hash: 8522f4d54ed82515c827516d9b49e71a0c2c15d0 [PR build]

vs-mobiletools-engineering-service2 · 2025-12-15T09:58:28Z

🚀 [CI Build #8522f4d] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 119 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 11 tests passed. [attempt 3] Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. [attempt 2] Html Report (VSDrops) Download

Pipeline on Agent
Hash: 8522f4d54ed82515c827516d9b49e71a0c2c15d0 [PR build]

rolfbjarne enabled auto-merge (squash) December 11, 2025 14:40

rolfbjarne requested a review from Copilot December 11, 2025 14:40

Copilot started reviewing on behalf of rolfbjarne December 11, 2025 14:40 View session

Auto-format source code

c0a00f5

Copilot AI reviewed Dec 11, 2025

View reviewed changes

src/Foundation/NSMutableSet_1.cs Outdated Show resolved Hide resolved

dalexsoto approved these changes Dec 11, 2025

View reviewed changes

This comment has been minimized.

Sign in to view

Update src/Foundation/NSMutableSet_1.cs

8522f4d

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

This comment has been minimized.

Sign in to view

rolfbjarne merged commit cf7f48f into main Dec 15, 2025
45 checks passed

rolfbjarne added the copilot label Feb 2, 2026

Conversation

rolfbjarne commented Dec 11, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Key Changes

Reviewed changes

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Dec 12, 2025

✅ [CI Build #8522f4d] Build passed (Build packages) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Dec 12, 2025

✅ [PR Build #8522f4d] Build passed (Detect API changes) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Dec 12, 2025

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

Uh oh!

vs-mobiletools-engineering-service2 commented Dec 12, 2025

✅ [CI Build #8522f4d] Build passed (Build macOS tests) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Dec 12, 2025

💻 [CI Build #8522f4d] Tests on macOS X64 - Mac Sonoma (14) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Dec 12, 2025

💻 [CI Build #8522f4d] Tests on macOS M1 - Mac Monterey (12) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Dec 12, 2025

💻 [CI Build #8522f4d] Tests on macOS M1 - Mac Ventura (13) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Dec 12, 2025

💻 [CI Build #8522f4d] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Dec 12, 2025

💻 [CI Build #8522f4d] Tests on macOS arm64 - Mac Tahoe (26) passed 💻

Uh oh!

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Dec 15, 2025

🚀 [CI Build #8522f4d] Test results 🚀

Test results

Tests counts

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants