[net11.0] Enable CoreCLR tests on x64.#24421
Conversation
There was a problem hiding this comment.
Pull request overview
This PR enables CoreCLR tests on x64 devices by removing a temporary workaround that was conditionally disabling these tests on x64 platforms. The change removes logic that was checking for ARM64 support and Mac platform to determine if CoreCLR tests should run, which was implemented as a workaround for a known runtime issue (dotnet/runtime#121631) that has now been resolved.
Key Changes
- Removed the
coreclr_worksandignore_coreclrvariables that were conditionally disabling CoreCLR tests on x64 platforms - Updated test variation configurations to use the standard
ignorevariable instead of the conditionalignore_coreclr
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ [PR Build #6376bd1] Build passed (Detect API changes) ✅Pipeline on Agent |
✅ [CI Build #6376bd1] Build passed (Build packages) ✅Pipeline on Agent |
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
✅ [CI Build #6376bd1] Build passed (Build macOS tests) ✅Pipeline on Agent |
💻 [CI Build #6376bd1] Tests on macOS M1 - Mac Monterey (12) passed 💻✅ All tests on macOS M1 - Mac Monterey (12) passed. Pipeline on Agent |
💻 [CI Build #6376bd1] Tests on macOS arm64 - Mac Sequoia (15) passed 💻✅ All tests on macOS arm64 - Mac Sequoia (15) passed. Pipeline on Agent |
💻 [CI Build #6376bd1] Tests on macOS X64 - Mac Sonoma (14) passed 💻✅ All tests on macOS X64 - Mac Sonoma (14) passed. Pipeline on Agent |
💻 [CI Build #6376bd1] Tests on macOS M1 - Mac Ventura (13) passed 💻✅ All tests on macOS M1 - Mac Ventura (13) passed. Pipeline on Agent |
💻 [CI Build #6376bd1] Tests on macOS arm64 - Mac Tahoe (26) passed 💻✅ All tests on macOS arm64 - Mac Tahoe (26) passed. Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
🚀 [CI Build #6376bd1] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 139 tests passed 🎉 Tests counts✅ cecil: All 1 tests passed. [attempt 2] Html Report (VSDrops) Download Pipeline on Agent |
Description
This PR enables CoreCLR tests on x64 devices.
Fixes #24316.
Continued from #24325.