[Network] Fix NWBrowseResult.TxtRecord to not throw an exception if there's no TxtRecord.#24295
Conversation
…here's no TxtRecord.
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the NWBrowseResult.TxtRecord property to handle cases where no TXT record is present, preventing an exception from being thrown. The property now correctly returns null when the native API returns IntPtr.Zero.
Key Changes
- Changed
TxtRecordfrom an expression-bodied property to a property with a getter that checks for null - Added nullable annotation (
NWTxtRecord?) to the return type - Implemented null check for
IntPtr.Zerobefore creating theNWTxtRecordinstance
✅ [CI Build #5adb0b8] Build passed (Build packages) ✅Pipeline on Agent |
✅ [PR Build #5adb0b8] Build passed (Detect API changes) ✅Pipeline on Agent |
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
✅ [CI Build #5adb0b8] Build passed (Build macOS tests) ✅Pipeline on Agent |
💻 [CI Build #5adb0b8] Tests on macOS X64 - Mac Sonoma (14) passed 💻✅ All tests on macOS X64 - Mac Sonoma (14) passed. Pipeline on Agent |
💻 [CI Build #5adb0b8] Tests on macOS M1 - Mac Monterey (12) passed 💻✅ All tests on macOS M1 - Mac Monterey (12) passed. Pipeline on Agent |
💻 [CI Build #5adb0b8] Tests on macOS arm64 - Mac Sequoia (15) passed 💻✅ All tests on macOS arm64 - Mac Sequoia (15) passed. Pipeline on Agent |
💻 [CI Build #5adb0b8] Tests on macOS M1 - Mac Ventura (13) passed 💻✅ All tests on macOS M1 - Mac Ventura (13) passed. Pipeline on Agent |
💻 [CI Build #5adb0b8] Tests on macOS arm64 - Mac Tahoe (26) passed 💻✅ All tests on macOS arm64 - Mac Tahoe (26) passed. Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
🚀 [CI Build #5adb0b8] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 120 tests passed 🎉 Tests counts✅ cecil: All 1 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
No description provided.