[tests] Fix test variations for monotouch-test. by rolfbjarne · Pull Request #24280 · dotnet/macios

rolfbjarne · 2025-11-18T11:41:26Z

These test variations need to go in the shared list of test variations,
because they contains conditional compilation symbols that need to be set for
referenced projects as well.

Also a few other improvements:

Order the test variations identically between the item group with descriptions and the property groups.
Add a sanity check to verify that if a test variation is specified, then something actually happens.
Use 'TrimMode' instead of 'LinkMode'+'MtouchLink' - this avoids forgetting to set either 'LinkMode' or 'MtouchLink'.

These test variations need to go in the shared list of test variations, because they contains conditional compilation symbols that need to be set for referenced projects as well. Also a few other improvements: * Order the test variations identically between the item group with descriptions and the property groups. * Add a sanity check to verify that if a test variation is specified, then something actually happens. * Use 'TrimMode' instead of 'LinkMode'+'MtouchLink' - this avoids forgetting to set either 'LinkMode' or 'MtouchLink'.

…h-test-variations

vs-mobiletools-engineering-service2 · 2025-11-19T23:07:09Z

✅ [CI Build #970419d] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 970419d82429bdf1c920859aa22d4f7eb4c0d198 [PR build]

vs-mobiletools-engineering-service2 · 2025-11-19T23:21:12Z

✅ [PR Build #970419d] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 970419d82429bdf1c920859aa22d4f7eb4c0d198 [PR build]

vs-mobiletools-engineering-service2 · 2025-11-19T23:42:30Z

✅ [CI Build #970419d] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 970419d82429bdf1c920859aa22d4f7eb4c0d198 [PR build]

vs-mobiletools-engineering-service2 · 2025-11-19T23:51:45Z

💻 [CI Build #970419d] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 970419d82429bdf1c920859aa22d4f7eb4c0d198 [PR build]

vs-mobiletools-engineering-service2 · 2025-11-19T23:55:37Z

💻 [CI Build #970419d] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 970419d82429bdf1c920859aa22d4f7eb4c0d198 [PR build]

vs-mobiletools-engineering-service2 · 2025-11-19T23:56:24Z

💻 [CI Build #970419d] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 970419d82429bdf1c920859aa22d4f7eb4c0d198 [PR build]

vs-mobiletools-engineering-service2 · 2025-11-19T23:57:05Z

💻 [CI Build #970419d] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

✅ All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: 970419d82429bdf1c920859aa22d4f7eb4c0d198 [PR build]

vs-mobiletools-engineering-service2 · 2025-11-19T23:57:58Z

💻 [CI Build #970419d] Tests on macOS arm64 - Mac Tahoe (26) passed 💻

✅ All tests on macOS arm64 - Mac Tahoe (26) passed.

Pipeline on Agent
Hash: 970419d82429bdf1c920859aa22d4f7eb4c0d198 [PR build]

vs-mobiletools-engineering-service2 · 2025-11-20T00:06:29Z

✅ API diff for current PR / commit

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

✅ API diff vs stable

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 970419d82429bdf1c920859aa22d4f7eb4c0d198 [PR build]

vs-mobiletools-engineering-service2 · 2025-11-21T08:42:06Z

🚀 [CI Build #970419d] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 117 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. [attempt 3] Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 9 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. [attempt 2] Html Report (VSDrops) Download

Pipeline on Agent
Hash: 970419d82429bdf1c920859aa22d4f7eb4c0d198 [PR build]

This comment has been minimized.

Sign in to view

rolfbjarne marked this pull request as ready for review November 18, 2025 19:11

rolfbjarne enabled auto-merge (squash) November 18, 2025 19:11

dalexsoto approved these changes Nov 19, 2025

View reviewed changes

Merge remote-tracking branch 'origin/main' into dev/rolf/fix-monotouc…

970419d

…h-test-variations

This comment has been minimized.

Sign in to view

rolfbjarne merged commit a6d135e into main Nov 21, 2025
45 checks passed

Conversation

rolfbjarne commented Nov 18, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Nov 19, 2025

✅ [CI Build #970419d] Build passed (Build packages) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Nov 19, 2025

✅ [PR Build #970419d] Build passed (Detect API changes) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Nov 19, 2025

✅ [CI Build #970419d] Build passed (Build macOS tests) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Nov 19, 2025

💻 [CI Build #970419d] Tests on macOS X64 - Mac Sonoma (14) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Nov 19, 2025

💻 [CI Build #970419d] Tests on macOS M1 - Mac Monterey (12) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Nov 19, 2025

💻 [CI Build #970419d] Tests on macOS M1 - Mac Ventura (13) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Nov 19, 2025

💻 [CI Build #970419d] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Nov 19, 2025

💻 [CI Build #970419d] Tests on macOS arm64 - Mac Tahoe (26) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Nov 20, 2025

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

Uh oh!

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Nov 21, 2025

🚀 [CI Build #970419d] Test results 🚀

Test results

Tests counts

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants