[Foundation] Fix nullability in NSUrlCredential. by rolfbjarne · Pull Request #24277 · dotnet/macios

rolfbjarne · 2025-11-18T09:50:52Z

This is file 15 of 47 files with nullability disabled in Foundation.

Changes:

Enabled nullable reference types
Made SecIdentity property return SecIdentity? (nullable) since it can return null when Identity handle is IntPtr.Zero
Replaced "To be added." XML documentation with proper documentation for all members
Added see cref attributes for better cross-referencing
Removed unnecessary whitespace in XML comments
Replaced manual null checks with ArgumentNullException.ThrowIfNull for cleaner code
Added returns documentation for all methods that were missing it

Contributes towards #17285.

This is file 15 of 47 files with nullability disabled in Foundation. Changes: - Enabled nullable reference types - Made SecIdentity property return SecIdentity? (nullable) since it can return null when Identity handle is IntPtr.Zero - Replaced "To be added." XML documentation with proper documentation for all members - Added see cref attributes for better cross-referencing - Removed unnecessary whitespace in XML comments - Replaced manual null checks with ArgumentNullException.ThrowIfNull for cleaner code - Added returns documentation for all methods that were missing it Contributes towards #17285.

Copilot

Pull Request Overview

This PR enables nullable reference types for the NSUrlCredential class in Foundation, contributing to the larger effort tracked in issue #17285. The changes improve code safety and documentation quality.

Key changes:

Enabled nullable reference types by adding #nullable enable
Updated the SecIdentity property return type to be nullable (SecIdentity?) to accurately reflect that it can return null
Replaced manual null checks with ArgumentNullException.ThrowIfNull for cleaner, more modern code

Copilot · 2025-11-18T10:04:56Z

src/Foundation/NSUrlCredential.cs

 		{
-			if (identity is null)
-				throw new ArgumentNullException ("identity");
+			ArgumentNullException.ThrowIfNull (identity);


The certificates parameter should have a null check added for consistency. The static method FromIdentityCertificatesPersistance checks both identity and certificates parameters (lines 35-36), but this constructor only checks identity. Since nullable reference types are now enabled and certificates is declared as non-nullable (SecCertificate []), a null check should be added here:

ArgumentNullException.ThrowIfNull (identity); ArgumentNullException.ThrowIfNull (certificates);

Suggested change

ArgumentNullException.ThrowIfNull (identity);

ArgumentNullException.ThrowIfNull (identity);

ArgumentNullException.ThrowIfNull (certificates);

…ullability-15-nsurlcredential

vs-mobiletools-engineering-service2 · 2025-11-19T23:14:39Z

✅ [CI Build #f384725] Build passed (Build packages) ✅

Pipeline on Agent
Hash: f384725caf782a935f1f7f7189977af0dfe58c94 [PR build]

vs-mobiletools-engineering-service2 · 2025-11-19T23:24:28Z

✅ [PR Build #f384725] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: f384725caf782a935f1f7f7189977af0dfe58c94 [PR build]

vs-mobiletools-engineering-service2 · 2025-11-19T23:52:07Z

✅ [CI Build #f384725] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: f384725caf782a935f1f7f7189977af0dfe58c94 [PR build]

vs-mobiletools-engineering-service2 · 2025-11-20T00:01:19Z

💻 [CI Build #f384725] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: f384725caf782a935f1f7f7189977af0dfe58c94 [PR build]

vs-mobiletools-engineering-service2 · 2025-11-20T00:04:56Z

💻 [CI Build #f384725] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: f384725caf782a935f1f7f7189977af0dfe58c94 [PR build]

vs-mobiletools-engineering-service2 · 2025-11-20T00:06:08Z

💻 [CI Build #f384725] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

✅ All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: f384725caf782a935f1f7f7189977af0dfe58c94 [PR build]

vs-mobiletools-engineering-service2 · 2025-11-20T00:09:25Z

💻 [CI Build #f384725] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: f384725caf782a935f1f7f7189977af0dfe58c94 [PR build]

vs-mobiletools-engineering-service2 · 2025-11-20T00:15:33Z

✅ API diff for current PR / commit

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

✅ API diff vs stable

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: f384725caf782a935f1f7f7189977af0dfe58c94 [PR build]

vs-mobiletools-engineering-service2 · 2025-11-20T00:25:22Z

💻 [CI Build #f384725] Tests on macOS arm64 - Mac Tahoe (26) passed 💻

✅ All tests on macOS arm64 - Mac Tahoe (26) passed.

Pipeline on Agent
Hash: f384725caf782a935f1f7f7189977af0dfe58c94 [PR build]

vs-mobiletools-engineering-service2 · 2025-11-20T01:21:42Z

🚀 [CI Build #f384725] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 124 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 11 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: f384725caf782a935f1f7f7189977af0dfe58c94 [PR build]

rolfbjarne enabled auto-merge (squash) November 18, 2025 09:50

rolfbjarne requested a review from Copilot November 18, 2025 09:55

Copilot started reviewing on behalf of rolfbjarne November 18, 2025 09:55 View session

Copilot finished reviewing on behalf of rolfbjarne November 18, 2025 09:58

Copilot AI reviewed Nov 18, 2025

View reviewed changes

This comment has been minimized.

Sign in to view

dalexsoto approved these changes Nov 18, 2025

View reviewed changes

Merge remote-tracking branch 'origin/main' into dev/rolf/foundation-n…

f384725

…ullability-15-nsurlcredential

rolfbjarne merged commit ef466ab into main Nov 20, 2025
45 checks passed

rolfbjarne added the copilot label Feb 2, 2026

	ArgumentNullException.ThrowIfNull (identity);
	ArgumentNullException.ThrowIfNull (identity);
	ArgumentNullException.ThrowIfNull (certificates);

Conversation

rolfbjarne commented Nov 18, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Nov 18, 2025

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Nov 19, 2025

✅ [CI Build #f384725] Build passed (Build packages) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Nov 19, 2025

✅ [PR Build #f384725] Build passed (Detect API changes) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Nov 19, 2025

✅ [CI Build #f384725] Build passed (Build macOS tests) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Nov 20, 2025

💻 [CI Build #f384725] Tests on macOS X64 - Mac Sonoma (14) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Nov 20, 2025

💻 [CI Build #f384725] Tests on macOS M1 - Mac Monterey (12) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Nov 20, 2025

💻 [CI Build #f384725] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Nov 20, 2025

💻 [CI Build #f384725] Tests on macOS M1 - Mac Ventura (13) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Nov 20, 2025

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

Uh oh!

vs-mobiletools-engineering-service2 commented Nov 20, 2025

💻 [CI Build #f384725] Tests on macOS arm64 - Mac Tahoe (26) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Nov 20, 2025

🚀 [CI Build #f384725] Test results 🚀

Test results

Tests counts

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants