[Foundation] Fix nullability in NSUrlProtectionSpace. by rolfbjarne · Pull Request #24271 · dotnet/macios

rolfbjarne · 2025-11-17T22:44:32Z

This is file 13 of 47 files with nullability disabled in Foundation.

Changes:

Enabled nullable reference types for the ServerSecTrust property
Made ServerSecTrust return SecTrust? (nullable) since it can return null when ServerTrust handle is IntPtr.Zero
Replaced "To be added." XML documentation with proper documentation for ServerSecTrust property
Added see cref attributes for better cross-referencing
Removed unnecessary whitespace in XML comments
Fixed NSUrlSessionHandler.cs to use null-forgiving operators when accessing ServerSecTrust in contexts where it's guaranteed to be non-null (when AuthenticationMethod is AuthenticationMethodServerTrust)

Contributes towards #17285.

This is file 13 of 47 files with nullability disabled in Foundation. Changes: - Enabled nullable reference types for the ServerSecTrust property - Made ServerSecTrust return SecTrust? (nullable) since it can return null when ServerTrust handle is IntPtr.Zero - Replaced "To be added." XML documentation with proper documentation for ServerSecTrust property - Added see cref attributes for better cross-referencing - Removed unnecessary whitespace in XML comments - Fixed NSUrlSessionHandler.cs to use null-forgiving operators when accessing ServerSecTrust in contexts where it's guaranteed to be non-null (when AuthenticationMethod is AuthenticationMethodServerTrust) Contributes towards #17285.

…ullability-13-nsurlprotectionspace

vs-mobiletools-engineering-service2 · 2025-11-19T23:01:19Z

✅ [PR Build #99c855d] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 99c855d1622ecaad03437c50afa3050c003d8645 [PR build]

vs-mobiletools-engineering-service2 · 2025-11-19T23:17:02Z

✅ [CI Build #99c855d] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 99c855d1622ecaad03437c50afa3050c003d8645 [PR build]

vs-mobiletools-engineering-service2 · 2025-11-19T23:28:03Z

✅ API diff for current PR / commit

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

✅ API diff vs stable

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 99c855d1622ecaad03437c50afa3050c003d8645 [PR build]

vs-mobiletools-engineering-service2 · 2025-11-19T23:45:48Z

✅ [CI Build #99c855d] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 99c855d1622ecaad03437c50afa3050c003d8645 [PR build]

vs-mobiletools-engineering-service2 · 2025-11-19T23:56:06Z

💻 [CI Build #99c855d] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 99c855d1622ecaad03437c50afa3050c003d8645 [PR build]

vs-mobiletools-engineering-service2 · 2025-11-19T23:58:57Z

💻 [CI Build #99c855d] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 99c855d1622ecaad03437c50afa3050c003d8645 [PR build]

vs-mobiletools-engineering-service2 · 2025-11-20T00:00:05Z

💻 [CI Build #99c855d] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

✅ All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: 99c855d1622ecaad03437c50afa3050c003d8645 [PR build]

vs-mobiletools-engineering-service2 · 2025-11-20T00:00:13Z

💻 [CI Build #99c855d] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 99c855d1622ecaad03437c50afa3050c003d8645 [PR build]

vs-mobiletools-engineering-service2 · 2025-11-20T00:08:58Z

💻 [CI Build #99c855d] Tests on macOS arm64 - Mac Tahoe (26) passed 💻

✅ All tests on macOS arm64 - Mac Tahoe (26) passed.

Pipeline on Agent
Hash: 99c855d1622ecaad03437c50afa3050c003d8645 [PR build]

vs-mobiletools-engineering-service2 · 2025-11-20T09:31:33Z

🚀 [CI Build #99c855d] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 126 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 6 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 11 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ monotouch (macOS): All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 11 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 99c855d1622ecaad03437c50afa3050c003d8645 [PR build]

rolfbjarne enabled auto-merge (squash) November 17, 2025 22:44

This comment has been minimized.

Sign in to view

dalexsoto approved these changes Nov 18, 2025

View reviewed changes

This comment has been minimized.

Sign in to view

Merge remote-tracking branch 'origin/main' into dev/rolf/foundation-n…

99c855d

…ullability-13-nsurlprotectionspace

This comment has been minimized.

Sign in to view

rolfbjarne merged commit 666c6f9 into main Nov 20, 2025
45 checks passed

rolfbjarne added the copilot label Feb 2, 2026

Conversation

rolfbjarne commented Nov 17, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Nov 19, 2025

✅ [PR Build #99c855d] Build passed (Detect API changes) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Nov 19, 2025

✅ [CI Build #99c855d] Build passed (Build packages) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Nov 19, 2025

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

Uh oh!

vs-mobiletools-engineering-service2 commented Nov 19, 2025

✅ [CI Build #99c855d] Build passed (Build macOS tests) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Nov 19, 2025

💻 [CI Build #99c855d] Tests on macOS X64 - Mac Sonoma (14) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Nov 19, 2025

💻 [CI Build #99c855d] Tests on macOS M1 - Mac Monterey (12) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Nov 20, 2025

💻 [CI Build #99c855d] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Nov 20, 2025

💻 [CI Build #99c855d] Tests on macOS M1 - Mac Ventura (13) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Nov 20, 2025

💻 [CI Build #99c855d] Tests on macOS arm64 - Mac Tahoe (26) passed 💻

Uh oh!

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Nov 20, 2025

🚀 [CI Build #99c855d] Test results 🚀

Test results

Tests counts

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants