Skip to content

[Foundation] Fix nullability in NSItemProvider.#24258

Merged
rolfbjarne merged 1 commit intomainfrom
dev/rolf/foundation-nullability-7-nsitemprovider
Nov 17, 2025
Merged

[Foundation] Fix nullability in NSItemProvider.#24258
rolfbjarne merged 1 commit intomainfrom
dev/rolf/foundation-nullability-7-nsitemprovider

Conversation

@rolfbjarne
Copy link
Member

@rolfbjarne rolfbjarne commented Nov 14, 2025

This is file 7 of 47 files with nullability disabled in Foundation.

  • Also improve NSItemProvider documentation (by Copilot):
    • Remove 'To be added.' placeholders.
    • Remove SupportedOSPlatform attributes without version numbers.
    • Improve XML comments with proper formatting and see cref attributes.
    • Remove unnecessary whitespace in documentation.

Contributes towards #17285.

@rolfbjarne
[Foundation] Fix nullability in NSItemProvider.
4ca12cf 
This is file 7 of 47 files with nullability disabled in Foundation.

* Also improve NSItemProvider documentation (by Copilot):
	* Remove 'To be added.' placeholders.
	* Remove SupportedOSPlatform attributes without version numbers.
	* Improve XML comments with proper formatting and see cref attributes.
	* Remove unnecessary whitespace in documentation.

Contributes towards #17285.
@rolfbjarne rolfbjarne enabled auto-merge (squash) November 14, 2025 23:06
@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Nov 15, 2025

✅ [CI Build #4ca12cf] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 4ca12cf3f945937be636170f5a0cf45af30e9b19 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Nov 15, 2025

✅ [PR Build #4ca12cf] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 4ca12cf3f945937be636170f5a0cf45af30e9b19 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Nov 15, 2025

✅ [CI Build #4ca12cf] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 4ca12cf3f945937be636170f5a0cf45af30e9b19 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Nov 15, 2025

💻 [CI Build #4ca12cf] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 4ca12cf3f945937be636170f5a0cf45af30e9b19 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Nov 15, 2025

💻 [CI Build #4ca12cf] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 4ca12cf3f945937be636170f5a0cf45af30e9b19 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Nov 15, 2025

💻 [CI Build #4ca12cf] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

✅ All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: 4ca12cf3f945937be636170f5a0cf45af30e9b19 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Nov 15, 2025

💻 [CI Build #4ca12cf] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 4ca12cf3f945937be636170f5a0cf45af30e9b19 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Nov 15, 2025

✅ API diff for current PR / commit

NET (empty diffs)

✅ API diff vs stable

NET (empty diffs)

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 4ca12cf3f945937be636170f5a0cf45af30e9b19 [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Nov 17, 2025

💻 [CI Build #4ca12cf] Tests on macOS arm64 - Mac Tahoe (26) passed 💻

✅ All tests on macOS arm64 - Mac Tahoe (26) passed.

Pipeline on Agent
Hash: 4ca12cf3f945937be636170f5a0cf45af30e9b19 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Nov 17, 2025

🚀 [CI Build #4ca12cf] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 117 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ monotouch (iOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 9 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 4ca12cf3f945937be636170f5a0cf45af30e9b19 [PR build]

@rolfbjarne rolfbjarne merged commit 9eea11d into main Nov 17, 2025
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dalexsoto dalexsoto dalexsoto approved these changes

Assignees

No one assigned

Labels

copilot

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rolfbjarne @vs-mobiletools-engineering-service2 @dalexsoto