[msbuild] Fix XcodeProject output path when using artifacts folder by Copilot · Pull Request #24224 · dotnet/macios

Copilot · 2025-11-12T02:30:44Z

When UseArtifactsOutput is enabled, $(IntermediateOutputPath) is absolute. Prepending $(MSBuildProjectDirectory) creates invalid nested paths like:

/project/src/MyApp/home/user/artifacts/obj/MyApp/Debug/net10.0-ios/xcode/

Changes

Removed $(MSBuildProjectDirectory)/ prefix from _XcodeProjectDefaultOutputPathRoot in Microsoft.MaciOS.Sdk.Xcode.targets to prevent path concatenation issues when IntermediateOutputPath is absolute
Modified CreateXcArchive.cs to call Path.GetFullPath() on OutputPath, DerivedDataPath, and PackageCachePath before using them in xcodebuild commands
Modified CreateXcFramework.cs to call Path.GetFullPath() on XcArchivePath and OutputPath before using them in xcodebuild commands

This dual approach ensures that:

The root cause in the MSBuild targets file is fixed by removing the problematic prefix
The C# task implementations provide defensive path handling by normalizing paths to absolute before use
When paths are relative (traditional builds), Path.GetFullPath() resolves them correctly relative to the current directory
When paths are already absolute (artifacts mode), Path.GetFullPath() returns them unchanged

Fixes #24222

Original prompt

This section details on the original issue you should resolve

<issue_title><XcodeProject> and artifacts folder fails</issue_title>
<issue_description>### Apple platform

No response

Framework version

net9.0-*

Affected platform version

All

Description

When using xcode project and artifacts, the xcode is put inside the project directory.

Steps to Reproduce

Add <XcodeProject

Enable artifacts

Build

Observe the files in <reporoot>src/AI/src/Essentials.AI/Users/matthew/Documents/GitHub/maui/artifacts/obj/Essentials.AI/Debug/net10.0-ios26.0

I see the

macios/dotnet/targets/Microsoft.MaciOS.Sdk.Xcode.targets

Line 16 in 2dc2c3d

<_XcodeProjectDefaultOutputPathRoot>$(MSBuildProjectDirectory)/$(IntermediateOutputPath)xcode/</_XcodeProjectDefaultOutputPathRoot>
<_XcodeProjectDefaultOutputPathRoot>$(MSBuildProjectDirectory)/$(IntermediateOutputPath)xcode/</_XcodeProjectDefaultOutputPathRoot>
This should probably not have the $(MSBuildProjectDirectory) at the start. In the old way, the $(IntermediateOutputPath) was relative (but could be absolute), the artifacts way is absolute as it could be anywhere.

Did you find any workaround?

No

Build logs

No response</issue_description>

Comments on the Issue (you are @copilot in this section)

Fixes <XcodeProject> and artifacts folder fails #24222

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: mattleibow <1096616+mattleibow@users.noreply.github.com>

dotnet/targets/Microsoft.MaciOS.Sdk.Xcode.targets

Co-authored-by: rolfbjarne <249268+rolfbjarne@users.noreply.github.com>

dotnet/targets/Microsoft.MaciOS.Sdk.Xcode.targets

Co-authored-by: rolfbjarne <249268+rolfbjarne@users.noreply.github.com>

vs-mobiletools-engineering-service2 · 2025-11-21T08:51:52Z

✅ [CI Build #bcefb10] Build passed (Build packages) ✅

Pipeline on Agent
Hash: bcefb10803e2da35ff48dc7ac3080b7c38bafea8 [PR build]

vs-mobiletools-engineering-service2 · 2025-11-21T09:06:39Z

✅ [PR Build #bcefb10] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: bcefb10803e2da35ff48dc7ac3080b7c38bafea8 [PR build]

vs-mobiletools-engineering-service2 · 2025-11-21T09:27:11Z

✅ [CI Build #bcefb10] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: bcefb10803e2da35ff48dc7ac3080b7c38bafea8 [PR build]

vs-mobiletools-engineering-service2 · 2025-11-21T09:43:13Z

💻 [CI Build #bcefb10] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: bcefb10803e2da35ff48dc7ac3080b7c38bafea8 [PR build]

vs-mobiletools-engineering-service2 · 2025-11-21T09:43:47Z

💻 [CI Build #bcefb10] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: bcefb10803e2da35ff48dc7ac3080b7c38bafea8 [PR build]

vs-mobiletools-engineering-service2 · 2025-11-21T09:48:17Z

💻 [CI Build #bcefb10] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: bcefb10803e2da35ff48dc7ac3080b7c38bafea8 [PR build]

vs-mobiletools-engineering-service2 · 2025-11-21T09:48:43Z

💻 [CI Build #bcefb10] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

✅ All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: bcefb10803e2da35ff48dc7ac3080b7c38bafea8 [PR build]

vs-mobiletools-engineering-service2 · 2025-11-21T09:51:08Z

💻 [CI Build #bcefb10] Tests on macOS arm64 - Mac Tahoe (26) passed 💻

✅ All tests on macOS arm64 - Mac Tahoe (26) passed.

Pipeline on Agent
Hash: bcefb10803e2da35ff48dc7ac3080b7c38bafea8 [PR build]

vs-mobiletools-engineering-service2 · 2025-11-21T09:56:10Z

✅ API diff for current PR / commit

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

✅ API diff vs stable

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: bcefb10803e2da35ff48dc7ac3080b7c38bafea8 [PR build]

vs-mobiletools-engineering-service2 · 2025-11-21T11:03:05Z

🚀 [CI Build #bcefb10] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 122 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 15 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 8 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: bcefb10803e2da35ff48dc7ac3080b7c38bafea8 [PR build]

Initial plan

9e9c3b3

Copilot AI assigned Copilot and mattleibow Nov 12, 2025

Copilot started work on behalf of mattleibow November 12, 2025 02:31 View session

Fix XcodeProject output path for artifacts mode

dd792ca

Co-authored-by: mattleibow <1096616+mattleibow@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Fix Xcode project path issue in artifacts~~ Fix XcodeProject output path when using artifacts folder Nov 12, 2025

Copilot AI requested a review from mattleibow November 12, 2025 02:41

Copilot finished work on behalf of mattleibow November 12, 2025 02:41

This comment has been minimized.

Sign in to view

rolfbjarne self-assigned this Nov 17, 2025

rolfbjarne reviewed Nov 20, 2025

View reviewed changes

dotnet/targets/Microsoft.MaciOS.Sdk.Xcode.targets Show resolved Hide resolved

Copilot started work on behalf of rolfbjarne November 20, 2025 10:02 View session

Convert paths to absolute in C# tasks instead of MSBuild targets

ad5a54f

Co-authored-by: rolfbjarne <249268+rolfbjarne@users.noreply.github.com>

Copilot AI requested a review from rolfbjarne November 20, 2025 10:09

Copilot finished work on behalf of rolfbjarne November 20, 2025 10:09

This comment has been minimized.

Sign in to view

rolfbjarne reviewed Nov 21, 2025

View reviewed changes

dotnet/targets/Microsoft.MaciOS.Sdk.Xcode.targets Outdated Show resolved Hide resolved

Copilot started work on behalf of rolfbjarne November 21, 2025 07:57 View session

Remove MSBuildProjectDirectory prefix from targets file

bcefb10

Co-authored-by: rolfbjarne <249268+rolfbjarne@users.noreply.github.com>

Copilot AI requested a review from rolfbjarne November 21, 2025 08:02

Copilot finished work on behalf of rolfbjarne November 21, 2025 08:02

rolfbjarne changed the title ~~Fix XcodeProject output path when using artifacts folder~~ [msbuild] Fix XcodeProject output path when using artifacts folder Dec 1, 2025

rolfbjarne approved these changes Dec 1, 2025

View reviewed changes

rolfbjarne marked this pull request as ready for review December 1, 2025 17:52

rolfbjarne requested review from emaf and mauroa as code owners December 1, 2025 17:52

emaf approved these changes Dec 1, 2025

View reviewed changes

mauroa approved these changes Dec 1, 2025

View reviewed changes

rolfbjarne merged commit 612bc9d into main Dec 2, 2025
41 checks passed

rolfbjarne deleted the copilot/fix-xcodeproject-artifacts-issue branch December 2, 2025 09:31

Conversation

Copilot AI commented Nov 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Framework version

Affected platform version

Description

Steps to Reproduce

Did you find any workaround?

Build logs

Comments on the Issue (you are @copilot in this section)

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Uh oh!

vs-mobiletools-engineering-service2 commented Nov 21, 2025

✅ [CI Build #bcefb10] Build passed (Build packages) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Nov 21, 2025

✅ [PR Build #bcefb10] Build passed (Detect API changes) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Nov 21, 2025

✅ [CI Build #bcefb10] Build passed (Build macOS tests) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Nov 21, 2025

💻 [CI Build #bcefb10] Tests on macOS M1 - Mac Monterey (12) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Nov 21, 2025

💻 [CI Build #bcefb10] Tests on macOS X64 - Mac Sonoma (14) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Nov 21, 2025

💻 [CI Build #bcefb10] Tests on macOS M1 - Mac Ventura (13) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Nov 21, 2025

💻 [CI Build #bcefb10] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Nov 21, 2025

💻 [CI Build #bcefb10] Tests on macOS arm64 - Mac Tahoe (26) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Nov 21, 2025

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

Uh oh!

vs-mobiletools-engineering-service2 commented Nov 21, 2025

🚀 [CI Build #bcefb10] Test results 🚀

Test results

Tests counts

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Copilot AI commented Nov 12, 2025 •

edited

Loading