[msbuild] Always run WriteItemsFromFile locally.#24211
Conversation
Always run WriteItemsFromFile locally, as these operations just read/write items from/to an XML file, this is something we don't need to run remotely when building from Windows. This improves the build performance and also fixes some inconsistencies we had were sometimes files were written locally and read remotely (or the other way around). This means we need to adjust any corresponding ReadItemsFromFile calls accordingly. It also allows us to remove the remoting support in WriteItemsFromFile, but we can't remove remoting support for ReadItemsFromFile, because sometimes we have to read files that aren't written with WriteItemsFromFile (they're written by other tasks), and these files will have been written remotely.
✅ [CI Build #39a2967] Build passed (Build packages) ✅Pipeline on Agent |
✅ [PR Build #39a2967] Build passed (Detect API changes) ✅Pipeline on Agent |
✅ [CI Build #39a2967] Build passed (Build macOS tests) ✅Pipeline on Agent |
💻 [CI Build #39a2967] Tests on macOS X64 - Mac Sonoma (14) passed 💻✅ All tests on macOS X64 - Mac Sonoma (14) passed. Pipeline on Agent |
💻 [CI Build #39a2967] Tests on macOS M1 - Mac Monterey (12) passed 💻✅ All tests on macOS M1 - Mac Monterey (12) passed. Pipeline on Agent |
💻 [CI Build #39a2967] Tests on macOS arm64 - Mac Tahoe (26) passed 💻✅ All tests on macOS arm64 - Mac Tahoe (26) passed. Pipeline on Agent |
💻 [CI Build #39a2967] Tests on macOS M1 - Mac Ventura (13) passed 💻✅ All tests on macOS M1 - Mac Ventura (13) passed. Pipeline on Agent |
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
💻 [CI Build #39a2967] Tests on macOS arm64 - Mac Sequoia (15) passed 💻✅ All tests on macOS arm64 - Mac Sequoia (15) passed. Pipeline on Agent |
🚀 [CI Build #39a2967] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 115 tests passed 🎉 Tests counts✅ cecil: All 1 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
Always run WriteItemsFromFile locally, as these operations just read/write items
from/to an XML file, this is something we don't need to run remotely when building
from Windows. This improves the build performance and also fixes some inconsistencies
we had were sometimes files were written locally and read remotely (or the other
way around).
This means we need to adjust any corresponding ReadItemsFromFile calls accordingly.
It also allows us to remove the remoting support in WriteItemsFromFile, but we
can't remove remoting support for ReadItemsFromFile, because sometimes we have
to read files that aren't written with WriteItemsFromFile (they're written by
other tasks), and these files will have been written remotely.