[Foundation] Fix nullability in NSDirectoryEnumerator. by rolfbjarne · Pull Request #24192 · dotnet/macios

rolfbjarne · 2025-11-06T19:08:41Z

This is file 4 of 47 files with nullability disabled in Foundation.

Also (by Copilot):

Improve XML documentation and nullability in NSDirectoryEnumerator.
Remove placeholder 'To be added.' comments and replace with proper documentation.
Remove unnecessary whitespace after triple-slash in XML comments.
Add proper attributes for type references.
Add comprehensive documentation for all IEnumerator implementations.
Document exception conditions for Reset and Current properties.

Contributes towards #17285.

This is file 4 of 47 files with nullability disabled in Foundation. Also (by Copilot): * Improve XML documentation and nullability in NSDirectoryEnumerator. * Remove placeholder 'To be added.' comments and replace with proper documentation. * Remove unnecessary whitespace after triple-slash in XML comments. * Add proper <see cref> attributes for type references. * Add comprehensive documentation for all IEnumerator implementations. * Document exception conditions for Reset and Current properties. Contributes towards #17285.

…ullability-4-nsdirectoryenumerator

vs-mobiletools-engineering-service2 · 2025-11-07T15:24:00Z

✅ [CI Build #fa70077] Build passed (Build packages) ✅

Pipeline on Agent
Hash: fa700771c7ccda69ba0ee18deabb88dd6ca527dd [PR build]

vs-mobiletools-engineering-service2 · 2025-11-07T15:27:32Z

✅ [PR Build #fa70077] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: fa700771c7ccda69ba0ee18deabb88dd6ca527dd [PR build]

vs-mobiletools-engineering-service2 · 2025-11-07T15:54:07Z

✅ API diff for current PR / commit

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

✅ API diff vs stable

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: fa700771c7ccda69ba0ee18deabb88dd6ca527dd [PR build]

vs-mobiletools-engineering-service2 · 2025-11-10T09:55:55Z

✅ [CI Build #fa70077] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: fa700771c7ccda69ba0ee18deabb88dd6ca527dd [PR build]

vs-mobiletools-engineering-service2 · 2025-11-10T10:10:28Z

💻 [CI Build #fa70077] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: fa700771c7ccda69ba0ee18deabb88dd6ca527dd [PR build]

vs-mobiletools-engineering-service2 · 2025-11-10T10:12:59Z

💻 [CI Build #fa70077] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: fa700771c7ccda69ba0ee18deabb88dd6ca527dd [PR build]

vs-mobiletools-engineering-service2 · 2025-11-10T10:17:26Z

💻 [CI Build #fa70077] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

✅ All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: fa700771c7ccda69ba0ee18deabb88dd6ca527dd [PR build]

vs-mobiletools-engineering-service2 · 2025-11-10T10:19:46Z

💻 [CI Build #fa70077] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: fa700771c7ccda69ba0ee18deabb88dd6ca527dd [PR build]

vs-mobiletools-engineering-service2 · 2025-11-10T10:44:43Z

💻 [CI Build #fa70077] Tests on macOS arm64 - Mac Tahoe (26) passed 💻

✅ All tests on macOS arm64 - Mac Tahoe (26) passed.

Pipeline on Agent
Hash: fa700771c7ccda69ba0ee18deabb88dd6ca527dd [PR build]

vs-mobiletools-engineering-service2 · 2025-11-10T10:48:23Z

🚀 [CI Build #fa70077] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 115 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 8 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: fa700771c7ccda69ba0ee18deabb88dd6ca527dd [PR build]

This comment has been minimized.

Sign in to view

dalexsoto approved these changes Nov 6, 2025

View reviewed changes

rolfbjarne enabled auto-merge (squash) November 7, 2025 07:41

This comment has been minimized.

Sign in to view

Merge remote-tracking branch 'origin/main' into dev/rolf/foundation-n…

fa70077

…ullability-4-nsdirectoryenumerator

This comment has been minimized.

Sign in to view

rolfbjarne merged commit 88798e0 into main Nov 10, 2025
45 checks passed

rolfbjarne added the copilot label Feb 2, 2026

Conversation

rolfbjarne commented Nov 6, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Nov 7, 2025

✅ [CI Build #fa70077] Build passed (Build packages) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Nov 7, 2025

✅ [PR Build #fa70077] Build passed (Detect API changes) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Nov 7, 2025

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

Uh oh!

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Nov 10, 2025

✅ [CI Build #fa70077] Build passed (Build macOS tests) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Nov 10, 2025

💻 [CI Build #fa70077] Tests on macOS X64 - Mac Sonoma (14) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Nov 10, 2025

💻 [CI Build #fa70077] Tests on macOS M1 - Mac Monterey (12) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Nov 10, 2025

💻 [CI Build #fa70077] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Nov 10, 2025

💻 [CI Build #fa70077] Tests on macOS M1 - Mac Ventura (13) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Nov 10, 2025

💻 [CI Build #fa70077] Tests on macOS arm64 - Mac Tahoe (26) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Nov 10, 2025

🚀 [CI Build #fa70077] Test results 🚀

Test results

Tests counts

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants