[bgen] Handle [DesignatedInitializer] being in two places at once. Fixes #10106. by rolfbjarne · Pull Request #23940 · dotnet/macios

rolfbjarne · 2025-10-07T11:02:48Z

We have the DesignatedInitializer attribute class in two places:

Binding attribute assembly.
Platform assembly.

And they're in different namespaces too.

This resulted in confusion in the generator, so fix that.

Also remove the version in the binding attribute assembly for XAMCORE_5_0,
since we only need one version.

#10106. We have the DesignatedInitializer attribute class in two places: * Binding attribute assembly. * Platform assembly. And they're in different namespaces too. This resulted in confusion in the generator, so fix that. Also remove the version in the binding attribute assembly for XAMCORE_5_0, since we only need one version. Fixes #10106.

vs-mobiletools-engineering-service2 · 2025-10-07T11:36:58Z

✅ [CI Build #bea4723] Build passed (Build packages) ✅

Pipeline on Agent
Hash: bea4723c4db11c097b7103e3a542c39cd12e4d17 [PR build]

vs-mobiletools-engineering-service2 · 2025-10-07T11:51:38Z

✅ [PR Build #bea4723] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: bea4723c4db11c097b7103e3a542c39cd12e4d17 [PR build]

vs-mobiletools-engineering-service2 · 2025-10-07T12:32:10Z

✅ API diff for current PR / commit

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

✅ API diff vs stable

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: bea4723c4db11c097b7103e3a542c39cd12e4d17 [PR build]

vs-mobiletools-engineering-service2 · 2025-10-07T12:33:33Z

✅ [CI Build #bea4723] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: bea4723c4db11c097b7103e3a542c39cd12e4d17 [PR build]

vs-mobiletools-engineering-service2 · 2025-10-07T12:42:32Z

💻 [CI Build #bea4723] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: bea4723c4db11c097b7103e3a542c39cd12e4d17 [PR build]

vs-mobiletools-engineering-service2 · 2025-10-07T12:46:18Z

💻 [CI Build #bea4723] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

✅ All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: bea4723c4db11c097b7103e3a542c39cd12e4d17 [PR build]

vs-mobiletools-engineering-service2 · 2025-10-07T12:48:34Z

💻 [CI Build #bea4723] Tests on macOS arm64 - Mac Tahoe (26) passed 💻

✅ All tests on macOS arm64 - Mac Tahoe (26) passed.

Pipeline on Agent
Hash: bea4723c4db11c097b7103e3a542c39cd12e4d17 [PR build]

vs-mobiletools-engineering-service2 · 2025-10-07T12:50:45Z

💻 [CI Build #bea4723] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: bea4723c4db11c097b7103e3a542c39cd12e4d17 [PR build]

vs-mobiletools-engineering-service2 · 2025-10-07T12:52:54Z

💻 [CI Build #bea4723] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: bea4723c4db11c097b7103e3a542c39cd12e4d17 [PR build]

vs-mobiletools-engineering-service2 · 2025-10-08T08:43:24Z

🚀 [CI Build #bea4723] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 126 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 6 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. [attempt 3] Html Report (VSDrops) Download
✅ monotouch (iOS): All 10 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 15 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 8 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: bea4723c4db11c097b7103e3a542c39cd12e4d17 [PR build]

rolfbjarne and others added 2 commits October 7, 2025 13:01

Auto-format source code

bea4723

rolfbjarne enabled auto-merge (squash) October 7, 2025 11:24

This comment has been minimized.

Sign in to view

dalexsoto approved these changes Oct 8, 2025

View reviewed changes

rolfbjarne merged commit 36fabde into main Oct 8, 2025
41 checks passed

rolfbjarne deleted the dev/rolf/issue-10106-designated-initializer branch October 8, 2025 09:35

Conversation

rolfbjarne commented Oct 7, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Oct 7, 2025

✅ [CI Build #bea4723] Build passed (Build packages) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 7, 2025

✅ [PR Build #bea4723] Build passed (Detect API changes) ✅

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Oct 7, 2025

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 7, 2025

✅ [CI Build #bea4723] Build passed (Build macOS tests) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 7, 2025

💻 [CI Build #bea4723] Tests on macOS X64 - Mac Sonoma (14) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 7, 2025

💻 [CI Build #bea4723] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 7, 2025

💻 [CI Build #bea4723] Tests on macOS arm64 - Mac Tahoe (26) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 7, 2025

💻 [CI Build #bea4723] Tests on macOS M1 - Mac Ventura (13) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 7, 2025

💻 [CI Build #bea4723] Tests on macOS M1 - Mac Monterey (12) passed 💻

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Oct 8, 2025

🚀 [CI Build #bea4723] Test results 🚀

Test results

Tests counts

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants