[msbuild] Add support for bundling original resources in libraries. Fixes #19028. by rolfbjarne · Pull Request #20822 · dotnet/macios

rolfbjarne · 2024-07-05T09:54:59Z

If a library references resources, until now we've pre-compile/pre-processed
some of those before embedding them the library. This applies to resources of
the following item groups:

AtlasTexture
BundleResource
Collada
CoreMLModel
ImageAsset
InterfaceDefinition
SceneKitAsset

However, pre-processing resources as a few problems:

It requires a native (Xcode) toolchain.
- This is unfortunate when building from Windows: the current approach is
  that when building a library as a referenced project, the remoting part
  is skipped, so all such resources are just dropped.
- It also means building on Linux doesn't work.
It makes it impossible to merge resources with the same name, if we wanted
to do that.

So I'm adding support for bundling the original resources in library projects.

This is enabled using the MSBuild property BundleOriginalResources=true,
which is turned off by default for .NET 9 and turned on by default for .NET 10+.

Additionally I've added PartialAppManifest items to the list of bundled
resources from class libraries.

This means that there are numerous task we don't have to remote to the Mac anymore (when bundling original resources) - in particular libraries can be fully built on Windows (or any other platform) now.

Fixes #19028.
Fixes #19513.

azure-pipelines · 2024-12-05T05:57:49Z

Azure Pipelines successfully started running 3 pipeline(s).

vs-mobiletools-engineering-service2 · 2024-12-05T06:40:59Z

✅ [CI Build] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 022ac03d13fa222339370c735a3de857fafc521b [PR build]

vs-mobiletools-engineering-service2 · 2024-12-05T07:29:42Z

✅ API diff for current PR / commit

.NET (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

✅ API diff vs stable

.NET (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 022ac03d13fa222339370c735a3de857fafc521b [PR build]

…le-original-resources-in-libraries

rolfbjarne · 2024-12-19T15:36:23Z

/azp run xamarin-macios-pr,xamarin-macios-apidiff

azure-pipelines · 2024-12-19T15:36:42Z

Azure Pipelines successfully started running 1 pipeline(s).

vs-mobiletools-engineering-service2 · 2024-12-19T16:21:14Z

✅ [CI Build] Build passed (Build packages) ✅

Pipeline on Agent
Hash: dfc01afd067be62691bb902bd2044884556a1e3e [PR build]

vs-mobiletools-engineering-service2 · 2024-12-19T16:41:19Z

✅ [CI Build] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: dfc01afd067be62691bb902bd2044884556a1e3e [PR build]

vs-mobiletools-engineering-service2 · 2024-12-19T16:55:20Z

💻 [CI Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: dfc01afd067be62691bb902bd2044884556a1e3e [PR build]

vs-mobiletools-engineering-service2 · 2024-12-19T16:56:54Z

💻 [CI Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: dfc01afd067be62691bb902bd2044884556a1e3e [PR build]

vs-mobiletools-engineering-service2 · 2024-12-19T16:57:10Z

💻 [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: dfc01afd067be62691bb902bd2044884556a1e3e [PR build]

vs-mobiletools-engineering-service2 · 2024-12-19T16:57:33Z

💻 [CI Build] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

✅ All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: dfc01afd067be62691bb902bd2044884556a1e3e [PR build]

vs-mobiletools-engineering-service2 · 2024-12-19T17:29:39Z

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: dfc01afd067be62691bb902bd2044884556a1e3e [PR build]

vs-mobiletools-engineering-service2 · 2024-12-20T09:43:46Z

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 105 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 40 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 7 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 10 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ monotouch (tvOS): All 7 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: dfc01afd067be62691bb902bd2044884556a1e3e [PR build]

rolfbjarne mentioned this pull request Jul 5, 2024

[msbuild] Add support for bundling original resources in libraries. Fixes #19028. #20557

Closed

This comment has been minimized.

Sign in to view

Merge remote-tracking branch 'origin/main' into dev/rolf/msbuild-bund…

dfc01af

…le-original-resources-in-libraries

This comment has been minimized.

Sign in to view

rolfbjarne merged commit 2943ab0 into main Dec 20, 2024

rolfbjarne deleted the dev/rolf/msbuild-bundle-original-resources-in-libraries branch December 20, 2024 09:56

Conversation

rolfbjarne commented Jul 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

azure-pipelines bot commented Dec 5, 2024

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Dec 5, 2024

✅ [CI Build] Build passed (Detect API changes) ✅

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Dec 5, 2024

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rolfbjarne commented Dec 19, 2024

Uh oh!

azure-pipelines bot commented Dec 19, 2024

Uh oh!

vs-mobiletools-engineering-service2 commented Dec 19, 2024

✅ [CI Build] Build passed (Build packages) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Dec 19, 2024

✅ [CI Build] Build passed (Build macOS tests) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Dec 19, 2024

💻 [CI Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Dec 19, 2024

💻 [CI Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Dec 19, 2024

💻 [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Dec 19, 2024

💻 [CI Build] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Dec 19, 2024

💻 [CI Build] Windows Integration Tests passed 💻

rolfbjarne commented Jul 5, 2024 •

edited

Loading