Skip to content

[Generator] Do not couple BindingTouch to the TypeCache.#19426

Merged
mandel-macaque merged 1 commit intodotnet:mainfrom
mandel-macaque:remove-bidingtouch-ref-from-cache
Nov 13, 2023
Merged

[Generator] Do not couple BindingTouch to the TypeCache.#19426
mandel-macaque merged 1 commit intodotnet:mainfrom
mandel-macaque:remove-bidingtouch-ref-from-cache

Conversation

@mandel-macaque
Copy link
Contributor

@mandel-macaque mandel-macaque commented Nov 10, 2023 •
edited by rolfbjarne
Loading

Pass the objects needed by the cache but not BT, that should help us in the future on how we are initializing the entire execution.

@mandel-macaque
[Generator] Do not couple BindingTouch to the TypeCache.
8ae0142 
Pass the objects needed by the cache but not BT, that should
help us in the future on how we are initializing the entirey execution.
@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Nov 10, 2023

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: 8ae0142b7570afaa97c1a8beb917c9d711559848 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Nov 10, 2023

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13.0) passed.

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Nov 10, 2023

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Nov 10, 2023

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Nov 10, 2023

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)
  • iOS (no change detected)
  • tvOS (no change detected)
  • watchOS (no change detected)
  • macOS (no change detected)
NET (empty diffs)
  • iOS: (empty diff detected)
  • tvOS: (empty diff detected)
  • MacCatalyst: (empty diff detected)
  • macOS: (empty diff detected)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)
.NET (No breaking changes)
Legacy Xamarin (stable) vs .NET

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 8ae0142b7570afaa97c1a8beb917c9d711559848 [PR build]

@mandel-macaque mandel-macaque added the generator Issues affecting the generator label Nov 10, 2023
@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Nov 10, 2023

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: simulator tests.

🎉 All 235 tests passed 🎉

Tests counts

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 6 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 41 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 8ae0142b7570afaa97c1a8beb917c9d711559848 [PR build]

@mandel-macaque mandel-macaque merged commit d5d7591 into dotnet:main Nov 13, 2023
@mandel-macaque mandel-macaque deleted the remove-bidingtouch-ref-from-cache branch November 13, 2023 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rolfbjarne rolfbjarne rolfbjarne approved these changes

+2 more reviewers

@dustin-wojciechowski dustin-wojciechowski dustin-wojciechowski approved these changes

@haritha-mohan haritha-mohan haritha-mohan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

generator Issues affecting the generator

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mandel-macaque @vs-mobiletools-engineering-service2 @rolfbjarne @dustin-wojciechowski @haritha-mohan