Skip to content

[net8.0] Revert "[tests] Find a workaround for #xamarin/maccore@2668."#18943

Merged
rolfbjarne merged 1 commit intodotnet:net8.0from
rolfbjarne:revert-bc272a944601d469f3944f7cf70f538723881e69
Sep 11, 2023
Merged

[net8.0] Revert "[tests] Find a workaround for #xamarin/maccore@2668."#18943
rolfbjarne merged 1 commit intodotnet:net8.0from
rolfbjarne:revert-bc272a944601d469f3944f7cf70f538723881e69

Conversation

@rolfbjarne
Copy link
Member

@rolfbjarne rolfbjarne commented Sep 6, 2023

This reverts commit bc272a9.

This workaround is no longer necessary.

Fixes #18164.

@rolfbjarne
Revert "[tests] Find a workaround for #xamarin/maccore@2668."
398684b 
This reverts commit bc272a9.

This workaround is no longer necessary.

Fixes dotnet#18164.
@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Sep 6, 2023

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: 398684b58473659015a706b8fdcdce17edd5d7f3 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Sep 6, 2023

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Sep 6, 2023

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)
  • iOS (no change detected)
  • tvOS (no change detected)
  • watchOS (no change detected)
  • macOS (no change detected)
NET (empty diffs)
  • iOS: (empty diff detected)
  • tvOS: (empty diff detected)
  • MacCatalyst: (empty diff detected)
  • macOS: (empty diff detected)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)
.NET (No breaking changes)
Legacy Xamarin (stable) vs .NET

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 398684b58473659015a706b8fdcdce17edd5d7f3 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Sep 6, 2023

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13.0) passed.

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Sep 6, 2023

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Sep 6, 2023

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: simulator tests.

🎉 All 233 tests passed 🎉

Tests counts

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 6 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 39 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 398684b58473659015a706b8fdcdce17edd5d7f3 [PR build]

@rolfbjarne rolfbjarne marked this pull request as ready for review September 7, 2023 05:36
@rolfbjarne rolfbjarne linked an issue Sep 7, 2023 that may be closed by this pull request
Verify workaround in #18159 is no longer necessary #18164
Closed
@rolfbjarne rolfbjarne merged commit 564e835 into dotnet:net8.0 Sep 11, 2023
@rolfbjarne rolfbjarne deleted the revert-bc272a944601d469f3944f7cf70f538723881e69 branch September 11, 2023 16:40
@rolfbjarne rolfbjarne mentioned this pull request Sep 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dalexsoto dalexsoto dalexsoto approved these changes

+1 more reviewer

@mandel-macaque mandel-macaque mandel-macaque approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Verify workaround in #18159 is no longer necessary

4 participants

@rolfbjarne @vs-mobiletools-engineering-service2 @dalexsoto @mandel-macaque