[dotnet] Point app extensions to any frameworks in the root app bundle. Fixes #17876. by rolfbjarne · Pull Request #18913 · dotnet/macios

rolfbjarne · 2023-09-01T16:55:45Z

Put any frameworks in app extensions in the Frameworks directory in the
containing app bundle. This saves a lot of space if the same framework is used
in both an app extension and the containing project (or multiple app
extensions).

Fixes #17876.
Fixes #17679.

Fixes dotnet#17876. Put any frameworks in app extensions in the Frameworks directory in the containing app bundle. This saves a lot of space if the same framework is used in both an app extension and the containing project (or multiple app extensions). Fixes dotnet#17876. Fixes dotnet#17679.

github-actions · 2023-09-01T17:01:18Z

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

emaf · 2023-09-06T17:10:54Z

msbuild/Xamarin.MacDev.Tasks/Tasks/GetFullPaths.cs

+		public string [] Metadata { get; set; } = Array.Empty<string> ();
+
+		[Output]
+		public ITaskItem [] Output { get; set; } = Array.Empty<ITaskItem> ();


I'd either make this a string or implement ITaskCallback.ShouldCreateOutputFile to return false, otherwise we will end up creating empty files on Windows, and I don't think this task should create any output files.

Oh, I see you are keeping the metadata from the original items, so I'd just implement ITaskCallback

@emaf fixed!

vs-mobiletools-engineering-service2 · 2023-09-07T08:47:17Z

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13.0) passed.

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2023-09-07T08:50:54Z

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2023-09-07T08:51:59Z

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: 73b3a1ce449554193e445350ac2d7f1e8ddcc968 [PR build]

vs-mobiletools-engineering-service2 · 2023-09-07T08:56:10Z

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2023-09-07T09:13:15Z

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)

~~iOS~~ (no change detected)
~~tvOS~~ (no change detected)
~~watchOS~~ (no change detected)
~~macOS~~ (no change detected)

NET (empty diffs)

~~iOS~~: (empty diff detected)
~~tvOS~~: (empty diff detected)
~~MacCatalyst~~: (empty diff detected)
~~macOS~~: (empty diff detected)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
watchOS: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

.NET (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)
Microsoft.iOS vs Microsoft.MacCatalyst: vsdrops gist

Legacy Xamarin (stable) vs .NET

iOS: vsdrops gist
tvOS: vsdrops gist
macOS: vsdrops gist

✅ Generator diff

Generator diff is empty

Pipeline on Agent
Hash: 73b3a1ce449554193e445350ac2d7f1e8ddcc968 [PR build]

vs-mobiletools-engineering-service2 · 2023-09-07T15:20:54Z

🔥 [CI Build] Test results 🔥

Test results

❌ Tests failed on VSTS: simulator tests

0 tests crashed, 1 tests failed, 234 tests passed.

Failures

❌ monotouch tests [attempt 2]

1 tests failed, 34 tests passed.

Details

monotouch-test/watchOS 32-bits - simulator/Release (all optimizations): TimedOut

Html Report (VSDrops) Download

Successes

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 73b3a1ce449554193e445350ac2d7f1e8ddcc968 [PR build]

rolfbjarne · 2023-09-07T15:23:21Z

Test failure is unrelated (https://github.com/xamarin/maccore/issues/2450).

rolfbjarne requested review from emaf and mauroa as code owners September 1, 2023 16:55

rolfbjarne added the bug If an issue is a bug or a pull request a bug fix label Sep 1, 2023

Auto-format source code

22f504d