[NativeAOT] Fix ILC warning for NSObject.RegisterToggleRef by simonrozsival · Pull Request #18889 · dotnet/macios

simonrozsival · 2023-08-31T12:38:45Z

This PR implements a workaround for the following build warning:

ILC: Method '[Microsoft.iOS]Foundation.NSObject.RegisterToggleRef(NSObject,native int,bool)' will always throw because:
Invalid IL or CLR metadata in 'Void Foundation.NSObject.RegisterToggleRef(Foundation.NSObject, IntPtr, Boolean)'

Ref #18524

rolfbjarne · 2023-08-31T16:37:54Z

tools/dotnet-linker/Steps/ManagedRegistrarStep.cs

 				md.IsPublic = true;
 				Annotations.Mark (md);
+			} else if (App.XamarinRuntime == XamarinRuntime.NativeAOT && Configuration.Profile.IsProductAssembly (assembly)) {
+				ImplementNSObjectRegisterToggleRefMethodStub ();


This doesn't really fit with the managed static registrar, but I think it's good for now.

At some point we might want to move random stuff out of the managed static registrar and into a "MakeEverythingWorkWithNativeAOTStep"...

…arning

rolfbjarne · 2023-09-05T07:09:37Z

The RegisterToggleRef method isn't there on macOS, so you'll have to exclude this logic there:

https://github.com/xamarin/xamarin-macios/blob/db6bc0ac4f53784d4cbcccd3fc4ebacc7c0221ca/src/Foundation/NSObject2.cs#L307-L310

github-actions · 2023-09-05T09:12:51Z

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

vs-mobiletools-engineering-service2 · 2023-09-05T10:37:35Z

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: c4bca2093c1668955400a51c379b7235ea842ef6 [PR build]

vs-mobiletools-engineering-service2 · 2023-09-05T10:44:54Z

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2023-09-05T10:54:07Z

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)

~~iOS~~ (no change detected)
~~tvOS~~ (no change detected)
~~watchOS~~ (no change detected)
~~macOS~~ (no change detected)

NET (empty diffs)

~~iOS~~: (empty diff detected)
~~tvOS~~: (empty diff detected)
~~MacCatalyst~~: (empty diff detected)
~~macOS~~: (empty diff detected)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
watchOS: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

.NET (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)
Microsoft.iOS vs Microsoft.MacCatalyst: vsdrops gist

Legacy Xamarin (stable) vs .NET

iOS: vsdrops gist
tvOS: vsdrops gist
macOS: vsdrops gist

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: c4bca2093c1668955400a51c379b7235ea842ef6 [PR build]

vs-mobiletools-engineering-service2 · 2023-09-05T14:23:06Z

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13.0) passed.

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2023-09-05T14:25:55Z

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2023-09-05T16:08:11Z

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: simulator tests.

🎉 All 228 tests passed 🎉

Tests counts

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 3 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 6 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 39 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: c4bca2093c1668955400a51c379b7235ea842ef6 [PR build]

simonrozsival and others added 2 commits August 31, 2023 14:38

Implement NSObject.RegisterToggleRef stub for NativeAOT to fix warning

a3f25c5

Auto-format source code

7c6c68d

This comment was marked as outdated.

Sign in to view

This comment has been minimized.

Sign in to view

rolfbjarne approved these changes Aug 31, 2023

View reviewed changes

mandel-macaque approved these changes Aug 31, 2023

View reviewed changes

Merge branch 'net8.0' into fix-nativeaot-nsobject-registertoggleref-w…

db3673d

…arning

This comment has been minimized.

Sign in to view

simonrozsival and others added 3 commits September 5, 2023 10:21

Do not try to implement the RegisterToggleRef stub on Mac

a9db400

Add a TODO comment

81fab74

Auto-format source code

c4bca20

rolfbjarne approved these changes Sep 6, 2023

View reviewed changes

rolfbjarne merged commit fb86b95 into dotnet:net8.0 Sep 6, 2023

Conversation

simonrozsival commented Aug 31, 2023

Uh oh!

This comment was marked as outdated.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rolfbjarne Aug 31, 2023

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rolfbjarne commented Sep 5, 2023

Uh oh!

github-actions bot commented Sep 5, 2023

⚠️ Your code has been reformatted. ⚠️

Uh oh!

vs-mobiletools-engineering-service2 commented Sep 5, 2023

💻 [CI Build] Windows Integration Tests passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Sep 5, 2023

📚 [PR Build] Artifacts 📚

Packages generated

Uh oh!

vs-mobiletools-engineering-service2 commented Sep 5, 2023

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

Uh oh!

vs-mobiletools-engineering-service2 commented Sep 5, 2023

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Sep 5, 2023

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Sep 5, 2023

🚀 [CI Build] Test results 🚀

Test results

Tests counts

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants