[NativeAOT] Do not root platform assembly by simonrozsival · Pull Request #18885 · dotnet/macios

simonrozsival · 2023-08-31T08:16:06Z

Based on testing several MAUI samples, there doesn't seem to be a reason to root the whole platform assembly anymore.

ivanpovazan

Thank you!

PS Additionally this would also complete #18584

simonrozsival · 2023-09-01T10:37:47Z

The MonoTouchFixtures.ARKit.ARConfigurationTest.Subclasses test (#5348) is failing: https://github.com/xamarin/xamarin-macios/blob/cd69385d41a8e292fc58e24ade1b38c0fb9e4a41/tests/monotouch-test/ARKit/ARConfigurationTest.cs#L50-L62

I think this can be expected when we don't root the whole assembly. I'm not sure what the correct fix is and if this test is even necessary in the NativeAOT configuration 🤔

rolfbjarne · 2023-09-01T12:11:10Z

The MonoTouchFixtures.ARKit.ARConfigurationTest.Subclasses test (#5348) is failing:

https://github.com/xamarin/xamarin-macios/blob/cd69385d41a8e292fc58e24ade1b38c0fb9e4a41/tests/monotouch-test/ARKit/ARConfigurationTest.cs#L50-L62

I think this can be expected when we don't root the whole assembly. I'm not sure what the correct fix is and if this test is even necessary in the NativeAOT configuration 🤔

This should fix it: #18908

vs-mobiletools-engineering-service2 · 2023-09-06T19:26:32Z

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: 0028b0c067e543a8fd77eaa70dc5437ea4767539 [PR build]

vs-mobiletools-engineering-service2 · 2023-09-06T19:51:15Z

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2023-09-06T20:41:58Z

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13.0) passed.

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2023-09-06T20:46:13Z

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2023-09-06T21:05:12Z

🔥 Failed to compare API and create generator diff 🔥

Failed to run apidiff

Pipeline on Agent
Hash: 0028b0c067e543a8fd77eaa70dc5437ea4767539 [PR build]

vs-mobiletools-engineering-service2 · 2023-09-07T06:07:14Z

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: simulator tests.

🎉 All 233 tests passed 🎉

Tests counts

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 6 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 39 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 0028b0c067e543a8fd77eaa70dc5437ea4767539 [PR build]

Remove rooting platform assembly

c566b3f

simonrozsival requested a review from ivanpovazan August 31, 2023 08:16

ivanpovazan approved these changes Aug 31, 2023

View reviewed changes

This comment has been minimized.

Sign in to view

simonrozsival marked this pull request as ready for review August 31, 2023 10:23

simonrozsival requested a review from rolfbjarne August 31, 2023 10:23

This comment has been minimized.

Sign in to view

Merge branch 'net8.0' into remove-rooting-platform-assembly

0028b0c

This comment has been minimized.

Sign in to view

rolfbjarne approved these changes Sep 7, 2023

View reviewed changes

rolfbjarne linked an issue Sep 7, 2023 that may be closed by this pull request

NativeAOT: Do not root the framework assembly #18779

Closed

rolfbjarne merged commit aef2c91 into dotnet:net8.0 Sep 7, 2023

rolfbjarne mentioned this pull request Sep 7, 2023

NativeAOT: Do not root the framework assembly #18779

Closed

Conversation

simonrozsival commented Aug 31, 2023

Uh oh!

ivanpovazan left a comment

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

simonrozsival commented Sep 1, 2023

Uh oh!

rolfbjarne commented Sep 1, 2023

Uh oh!

vs-mobiletools-engineering-service2 commented Sep 6, 2023

💻 [CI Build] Windows Integration Tests passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Sep 6, 2023

📚 [PR Build] Artifacts 📚

Packages generated

Uh oh!

vs-mobiletools-engineering-service2 commented Sep 6, 2023

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Sep 6, 2023

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Sep 6, 2023

Uh oh!

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Sep 7, 2023

🚀 [CI Build] Test results 🚀

Test results

Tests counts

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants