Skip to content

Fix _DefaultLinkMode for NativeAOT.#18560

Merged
dalexsoto merged 1 commit intodotnet:net8.0from
filipnavara:linkmode2
Jul 20, 2023
Merged

Fix _DefaultLinkMode for NativeAOT.#18560
dalexsoto merged 1 commit intodotnet:net8.0from
filipnavara:linkmode2

Conversation

@filipnavara
Copy link
Member

@filipnavara filipnavara commented Jul 17, 2023

Alternative to #18530, see #18530 (comment)
Contributes to #18482

@ivanpovazan
Copy link
Member

ivanpovazan commented Jul 17, 2023

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Jul 17, 2023

Azure Pipelines successfully started running 1 pipeline(s).

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Jul 17, 2023

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: 323b1e44f5272bbaae1e8cb66def9aff80210a6b [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Jul 17, 2023

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Jul 17, 2023

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Jul 17, 2023

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13.0) passed.

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Jul 17, 2023

✅ API diff for current PR / commit

NET (empty diffs)
  • iOS: (empty diff detected)
  • tvOS: (empty diff detected)
  • MacCatalyst: (empty diff detected)
  • macOS: (empty diff detected)

❗ API diff vs stable (Breaking changes)

.NET (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
  • iOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
  • tvOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
  • MacCatalyst: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
  • macOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
  • Microsoft.iOS vs Microsoft.MacCatalyst: vsdrops gist

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 323b1e44f5272bbaae1e8cb66def9aff80210a6b [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Jul 17, 2023

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: simulator tests.

🎉 All 92 tests passed 🎉

Tests counts

⚠️ bcl: No tests selected. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ framework: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 1 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 4 tests passed. Html Report (VSDrops) Download
⚠️ install_source: No tests selected. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 40 tests passed. Html Report (VSDrops) Download
⚠️ mac_binding_project: No tests selected. Html Report (VSDrops) Download
⚠️ mmp: No tests selected. Html Report (VSDrops) Download
⚠️ mononative: No tests selected. Html Report (VSDrops) Download
✅ monotouch: All 26 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
⚠️ mtouch: No tests selected. Html Report (VSDrops) Download
⚠️ xammac: No tests selected. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 323b1e44f5272bbaae1e8cb66def9aff80210a6b [PR build]

@filipnavara filipnavara marked this pull request as ready for review July 17, 2023 19:28
@dalexsoto dalexsoto added the community Community contribution ❤ label Jul 18, 2023
ivanpovazan
ivanpovazan approved these changes Jul 19, 2023
View reviewed changes
Copy link
Member

@ivanpovazan ivanpovazan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!
I double checked this with MAUI sample on IOS, works as expected.

@filipnavara should we wait for you to test on your macOS support work before merging in?

@filipnavara
Copy link
Member Author

filipnavara commented Jul 19, 2023

I did some limited testing and I can confirm that the MSBuild properties look sane for my use case. (I didn't do full rebase of all necessary PRs to check the executable on output yet)

@dalexsoto dalexsoto merged commit d635e6d into dotnet:net8.0 Jul 20, 2023
@filipnavara filipnavara deleted the linkmode2 branch July 20, 2023 15:12
@filipnavara filipnavara mentioned this pull request Jul 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dalexsoto dalexsoto dalexsoto approved these changes

@ivanpovazan ivanpovazan ivanpovazan approved these changes

+1 more reviewer

@haritha-mohan haritha-mohan haritha-mohan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

community Community contribution ❤

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@filipnavara @ivanpovazan @vs-mobiletools-engineering-service2 @dalexsoto @haritha-mohan