Skip to content

[Localization] Remove BOM#18042

Merged
tj-devel709 merged 1 commit intodotnet:mainfrom
tj-devel709:LocalizationBOM
Apr 13, 2023
Merged

[Localization] Remove BOM#18042
tj-devel709 merged 1 commit intodotnet:mainfrom
tj-devel709:LocalizationBOM

Conversation

@tj-devel709
Copy link
Member

@tj-devel709 tj-devel709 commented Apr 13, 2023

Followed the steps outlined here by the Loc team to remove the BOMs from our check-in: https://ceapex.visualstudio.com/CEINTL/_workitems/edit/816066

@tj-devel709 tj-devel709 added the not-notes-worthy Ignore for release notes label Apr 13, 2023
@tj-devel709 tj-devel709 added this to the Future milestone Apr 13, 2023
@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Apr 13, 2023

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: 68647bd997cbced30be0c516c21f4aa365b059af [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Apr 13, 2023

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: 68647bd997cbced30be0c516c21f4aa365b059af [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Apr 13, 2023

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)
  • iOS (no change detected)
  • tvOS (no change detected)
  • watchOS (no change detected)
  • macOS (no change detected)
NET (empty diffs)
  • iOS: (empty diff detected)
  • tvOS: (empty diff detected)
  • MacCatalyst: (empty diff detected)
  • macOS: (empty diff detected)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)
.NET (No breaking changes)
Legacy Xamarin (stable) vs .NET

✅ Generator diff

Generator diff is empty

Pipeline on Agent
Hash: 68647bd997cbced30be0c516c21f4aa365b059af [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Apr 13, 2023

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13.0) passed.

Pipeline on Agent
Hash: 68647bd997cbced30be0c516c21f4aa365b059af [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Apr 13, 2023

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent XAMBOT-1023.Ventura
Hash: 68647bd997cbced30be0c516c21f4aa365b059af [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Apr 13, 2023

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: simulator tests.

🎉 All 225 tests passed 🎉

Tests counts

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 25 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 68647bd997cbced30be0c516c21f4aa365b059af [PR build]

@tj-devel709 tj-devel709 merged commit 291fc50 into dotnet:main Apr 13, 2023
@tj-devel709 tj-devel709 mentioned this pull request Apr 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rolfbjarne rolfbjarne rolfbjarne approved these changes

+1 more reviewer

@haritha-mohan haritha-mohan haritha-mohan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

not-notes-worthy Ignore for release notes

Projects

None yet

Milestone

Future

Development

Successfully merging this pull request may close these issues.

4 participants

@tj-devel709 @vs-mobiletools-engineering-service2 @rolfbjarne @haritha-mohan