Skip to content

[msbuild] Honor any existing values for HotRestartSignedAppOutputDir and HotRestartAppBundlePath.#18014

Merged
rolfbjarne merged 1 commit intodotnet:mainfrom
rolfbjarne:hotrestart-allow-dir-overrices
Apr 11, 2023
Merged

[msbuild] Honor any existing values for HotRestartSignedAppOutputDir and HotRestartAppBundlePath.#18014
rolfbjarne merged 1 commit intodotnet:mainfrom
rolfbjarne:hotrestart-allow-dir-overrices

Conversation

@rolfbjarne
Copy link
Member

@rolfbjarne rolfbjarne commented Apr 10, 2023

This makes it easier to write tests that verify the files written in this paths,
because the tests can specify these output directories instead of evaluating a project
file or duplicating the logic to compute them.

Additionally, the tests can also easily make sure the output is cleaned up once the test is done.

@rolfbjarne
[msbuild] Honor any existing values for HotRestartSignedAppOutputDir …
5a3e51c 
…and HotRestartAppBundlePath.

This makes it easier to write tests that verify the files written in this paths,
because the tests can specify these output directories instead of evaluating a project
file or duplicating the logic to compute them.

Additionally, the tests can also easily make sure the output is cleaned up once the test is done.
@rolfbjarne rolfbjarne requested review from emaf and mauroa as code owners April 10, 2023 15:23
@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Apr 10, 2023

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)
  • iOS (no change detected)
  • tvOS (no change detected)
  • watchOS (no change detected)
  • macOS (no change detected)
NET (empty diffs)
  • iOS: (empty diff detected)
  • tvOS: (empty diff detected)
  • MacCatalyst: (empty diff detected)
  • macOS: (empty diff detected)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)
.NET (No breaking changes)
Legacy Xamarin (stable) vs .NET

✅ Generator diff

Generator diff is empty

Pipeline on Agent
Hash: 5a3e51ce936d534fed753d8359cd580fb7e0470b [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Apr 10, 2023

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: 5a3e51ce936d534fed753d8359cd580fb7e0470b [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Apr 10, 2023

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13.0) passed.

Pipeline on Agent
Hash: 5a3e51ce936d534fed753d8359cd580fb7e0470b [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Apr 10, 2023

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: 5a3e51ce936d534fed753d8359cd580fb7e0470b [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Apr 10, 2023

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent XAMBOT-1195.Ventura
Hash: 5a3e51ce936d534fed753d8359cd580fb7e0470b [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Apr 10, 2023

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: simulator tests.

🎉 All 225 tests passed 🎉

Tests counts

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 25 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 5a3e51ce936d534fed753d8359cd580fb7e0470b [PR build]

@rolfbjarne rolfbjarne merged commit 5a3248d into dotnet:main Apr 11, 2023
@rolfbjarne rolfbjarne deleted the hotrestart-allow-dir-overrices branch April 11, 2023 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dalexsoto dalexsoto dalexsoto approved these changes

@mauroa mauroa mauroa approved these changes

@emaf emaf emaf approved these changes

@tj-devel709 tj-devel709 tj-devel709 approved these changes

+1 more reviewer

@haritha-mohan haritha-mohan haritha-mohan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@rolfbjarne @vs-mobiletools-engineering-service2 @dalexsoto @mauroa @emaf @tj-devel709 @haritha-mohan