Skip to content

[xcode14.3] [msbuild] Get RecursiveDir directory name only if it isn't empty#17989

Merged
dalexsoto merged 1 commit intodotnet:xcode14.3from
vs-mobiletools-engineering-service2:backport-pr-17988-to-xcode14.3
Apr 6, 2023
Merged

[xcode14.3] [msbuild] Get RecursiveDir directory name only if it isn't empty#17989
dalexsoto merged 1 commit intodotnet:xcode14.3from
vs-mobiletools-engineering-service2:backport-pr-17988-to-xcode14.3

Conversation

@vs-mobiletools-engineering-service2
Copy link
Collaborator

@vs-mobiletools-engineering-service2 vs-mobiletools-engineering-service2 commented Apr 6, 2023

If the RecursiveDir metadata is empty, the GetDirectoryName method throws an error because it isn't a valid path. This can happen on VS design time builds.

Backport of #17988

@emaf
[msbuild] Get RecursiveDir directory name only if it isn't empty
29a4971 
If the `RecursiveDir` metadata is empty, the GetDirectoryName method throws an error because it isn't a valid path. This can happen on VS design time builds.
@vs-mobiletools-engineering-service2
Copy link
Collaborator Author

vs-mobiletools-engineering-service2 commented Apr 6, 2023

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: 29a4971d7ac1448445f4a1dc7524d9877157d7d4 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator Author

vs-mobiletools-engineering-service2 commented Apr 6, 2023

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13.0) passed.

Pipeline on Agent
Hash: 29a4971d7ac1448445f4a1dc7524d9877157d7d4 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator Author

vs-mobiletools-engineering-service2 commented Apr 6, 2023

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent XAMBOT-1032.Ventura
Hash: 29a4971d7ac1448445f4a1dc7524d9877157d7d4 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator Author

vs-mobiletools-engineering-service2 commented Apr 6, 2023

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: 29a4971d7ac1448445f4a1dc7524d9877157d7d4 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator Author

vs-mobiletools-engineering-service2 commented Apr 6, 2023

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)
  • iOS (no change detected)
  • tvOS (no change detected)
  • watchOS (no change detected)
  • macOS (no change detected)
NET (empty diffs)
  • iOS: (empty diff detected)
  • tvOS: (empty diff detected)
  • MacCatalyst: (empty diff detected)
  • macOS: (empty diff detected)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)
.NET (No breaking changes)
Legacy Xamarin (stable) vs .NET

✅ Generator diff

Generator diff is empty

Pipeline on Agent
Hash: 29a4971d7ac1448445f4a1dc7524d9877157d7d4 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator Author

vs-mobiletools-engineering-service2 commented Apr 6, 2023

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: simulator tests.

🎉 All 150 tests passed 🎉

Tests counts

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 3 tests passed. Html Report (VSDrops) Download
✅ framework: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 1 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 3 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 25 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 12 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 29a4971d7ac1448445f4a1dc7524d9877157d7d4 [PR build]

@dalexsoto dalexsoto merged commit f0c4c27 into dotnet:xcode14.3 Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dalexsoto dalexsoto dalexsoto approved these changes

Assignees

No one assigned

Labels

backported

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vs-mobiletools-engineering-service2 @dalexsoto @emaf