Skip to content

[tests] Add new cecil tests to verify correct block literal usage in our own code. Fixes #15783.#17794

Merged
rolfbjarne merged 2 commits intodotnet:mainfrom
rolfbjarne:tests-cecil-blocks
Mar 15, 2023
Merged

[tests] Add new cecil tests to verify correct block literal usage in our own code. Fixes #15783.#17794
rolfbjarne merged 2 commits intodotnet:mainfrom
rolfbjarne:tests-cecil-blocks

Conversation

@rolfbjarne
Copy link
Member

@rolfbjarne rolfbjarne commented Mar 14, 2023

This is the final step in our improved block support.

Fixes #15783.

@rolfbjarne
[tests] Add new cecil tests to verify correct block literal usage in …
0065345 
…our own code. Fixes dotnet#15783.

This is the final step in our improved block support.

Fixes dotnet#15783.
dalexsoto
dalexsoto approved these changes Mar 14, 2023
View reviewed changes
Copy link
Member

@dalexsoto dalexsoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
mandel-macaque
mandel-macaque approved these changes Mar 14, 2023
View reviewed changes
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@rolfbjarne @mandel-macaque
Update tests/cecil-tests/BlittablePInvokes.cs
7104dc8 
Co-authored-by: Manuel de la Pena <mandel@microsoft.com>
@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Mar 15, 2023

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: 7104dc81161b7656d7d5395ddceae569a2722796 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Mar 15, 2023

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)
  • iOS (no change detected)
  • tvOS (no change detected)
  • watchOS (no change detected)
  • macOS (no change detected)
NET (empty diffs)
  • iOS: (empty diff detected)
  • tvOS: (empty diff detected)
  • MacCatalyst: (empty diff detected)
  • macOS: (empty diff detected)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)
.NET (No breaking changes)
Legacy Xamarin (stable) vs .NET

✅ Generator diff

Generator diff is empty

Pipeline on Agent
Hash: 7104dc81161b7656d7d5395ddceae569a2722796 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Mar 15, 2023

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13.0) passed.

Pipeline on Agent
Hash: 7104dc81161b7656d7d5395ddceae569a2722796 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Mar 15, 2023

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: 7104dc81161b7656d7d5395ddceae569a2722796 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Mar 15, 2023

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent XAMBOT-1023.Ventura
Hash: 7104dc81161b7656d7d5395ddceae569a2722796 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Mar 15, 2023

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: simulator tests.

🎉 All 225 tests passed 🎉

Tests counts

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 25 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 7104dc81161b7656d7d5395ddceae569a2722796 [PR build]

@rolfbjarne rolfbjarne merged commit 0faf60c into dotnet:main Mar 15, 2023
@rolfbjarne rolfbjarne deleted the tests-cecil-blocks branch March 15, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dalexsoto dalexsoto dalexsoto approved these changes

+1 more reviewer

@mandel-macaque mandel-macaque mandel-macaque approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Redesign Block support to make it work with UnmanagedCallersOnlyAttribute

4 participants

@rolfbjarne @vs-mobiletools-engineering-service2 @dalexsoto @mandel-macaque