Skip to content

[PushToTalk] Add missing Model attribute to the PTChannelManagerDelegate and PTChannelRestorationDelegate declarations. Fixes #16792.#17273

Merged
rolfbjarne merged 4 commits intodotnet:mainfrom
rolfbjarne:issue-16792
Jan 19, 2023
Merged

Conversation

@rolfbjarne
Copy link
Member

@rolfbjarne rolfbjarne commented Jan 18, 2023

Fixes #16792.

@rolfbjarne
[PushToTalk] Add missing Model attribute to the PTChannelManagerDeleg…
86fb206 
…ate and PTChannelRestorationDelegate declarations. Fixes dotnet#16792.

Fixes dotnet#16792.
@rolfbjarne rolfbjarne added the bug If an issue is a bug or a pull request a bug fix label Jan 18, 2023
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Jan 18, 2023

🔥 Failed to compute test summaries on VSTS: simulator tests 🔥

Failed to compute test summaries: Cannot find path 'D:\a\1\s\Reports' because it does not exist..

Pipeline on Agent
Merge 86fb206 into 4bf97d1

@github-actions
Copy link
Contributor

github-actions bot commented Jan 18, 2023

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
dalexsoto
dalexsoto approved these changes Jan 18, 2023
View reviewed changes
Copy link
Member

@dalexsoto dalexsoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch, I 💭 we had a test for that scenario of Protocol + Basetype but no Model added

@rolfbjarne rolfbjarne mentioned this pull request Jan 18, 2023
Closed
@rolfbjarne
Copy link
Member Author

rolfbjarne commented Jan 18, 2023

Ouch, I 💭 we had a test for that scenario of Protocol + Basetype but no Model added

#17286

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Jan 18, 2023

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)
  • iOS (no change detected)
  • tvOS (no change detected)
  • watchOS (no change detected)
  • macOS (no change detected)
NET (empty diffs)
  • iOS: (empty diff detected)
  • tvOS: (empty diff detected)
  • MacCatalyst: (empty diff detected)
  • macOS: (empty diff detected)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)
.NET (No breaking changes)
Legacy Xamarin (stable) vs .NET

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 288be719210a3a60ea362118e1e509a0cc4bad72 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Jan 18, 2023

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: 288be719210a3a60ea362118e1e509a0cc4bad72 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Jan 19, 2023

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent XAMBOT-1023.Monterey'
Hash: 288be719210a3a60ea362118e1e509a0cc4bad72 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Jan 19, 2023

🔥 [CI Build] Test results 🔥

Test results

❌ Tests failed on VSTS: simulator tests

0 tests crashed, 1 tests failed, 224 tests passed.

Failures

❌ bcl tests

1 tests failed, 68 tests passed.
Details
  • [NUnit] Mono BCL tests group 2/tvOS - simulator/Debug: TimedOut

Html Report (VSDrops) Download

Successes

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 25 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 288be719210a3a60ea362118e1e509a0cc4bad72 [PR build]

@rolfbjarne
Copy link
Member Author

rolfbjarne commented Jan 19, 2023

Test failure is unrelated (https://github.com/xamarin/maccore/issues/2450).

@rolfbjarne rolfbjarne merged commit 30cab5a into dotnet:main Jan 19, 2023
@rolfbjarne rolfbjarne deleted the issue-16792 branch January 19, 2023 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dalexsoto dalexsoto dalexsoto approved these changes

@tj-devel709 tj-devel709 tj-devel709 approved these changes

Assignees

No one assigned

Labels

bug If an issue is a bug or a pull request a bug fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

PTChannelManagerDelegate segfaults when constructed

4 participants

@rolfbjarne @vs-mobiletools-engineering-service2 @dalexsoto @tj-devel709