[dotnet] Remove Runtime.Arch and ObjCRuntime.Arch from Mac Catalyst. Fixes #10312.#13562
Conversation
…atalyst. * In most cases use helper asserts/functions in the TestRuntime code instead of calling Runtime.Arch. * In the remaining cases adjust #if code to have the same logic for Mac Catalyst as macOS already has.
|
@rolfbjarne we need to check this by hand, device tests are not working atm until I can work on them post-vacation. |
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View dotnet API diffView dotnet legacy API diffAPI & Generator diffℹ️ API Diff (from PR only) (please review changes) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results3 tests failed, 216 tests passed.Failed tests
Pipeline on Agent XAMBOT-1094.BigSur' |
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View dotnet API diffView dotnet legacy API diffAPI Current PR diffℹ️ API Diff (from PR only) (please review changes) View dotnet API diffView dotnet legacy API diffGenerator diff✅ Generator Diff (no change) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results1 tests failed, 234 tests passed.Failed tests
Pipeline on Agent XAMBOT-1096.BigSur' |
|
Test failure is unrelated (https://github.com/xamarin/maccore/issues/2414). |
I ran the device tests locally, and didn't run into any problems. |
Remove Runtime.Arch and ObjCRuntime.Arch from Mac Catalyst, because they don't
apply for a Mac Catalyst app (which is neither a simulator environment, nor a
device environment).
This means that code using these APIs will have to be re-evaluated to
determine what's the correct behavior for Mac Catalyst.
Also update our tests accordingly.
Fixes #10312.