[Security] Remove the SslCipherSuite enum from .NET. Fixes #11498.#13307
Merged
rolfbjarne merged 1 commit intodotnet:mainfrom Nov 8, 2021
Merged
[Security] Remove the SslCipherSuite enum from .NET. Fixes #11498.#13307rolfbjarne merged 1 commit intodotnet:mainfrom
rolfbjarne merged 1 commit intodotnet:mainfrom
Conversation
* Remove the SslCipherSuite enum from .NET, it's complicated to implement correctly on macOS for both x64 and arm64, and it's also obsolete, so just remove it. * Change the type for NSUrlSessionTaskTransactionMetrics.NegotiatedTlsCipherSuite to be TlsCipherSuite instead of SslCipherSuite for .NET (this is in fact the correct value according to the headers). Fixes dotnet#11498.
chamons
approved these changes
Nov 8, 2021
Collaborator
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffView dotnet API diffView dotnet legacy API diffAPI & Generator diffℹ️ API Diff (from PR only) (please review changes) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results5 tests failed, 94 tests passed.Failed tests
Pipeline on Agent XAMBOT-1097.BigSur' |
Member
Author
|
Test failures are unrelated (https://github.com/xamarin/maccore/issues/2525). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
correctly on macOS for both x64 and arm64, and it's also obsolete, so just
remove it.
to be TlsCipherSuite instead of SslCipherSuite for .NET (this is in fact the
correct value according to the headers).
Fixes #11498.