Skip to content

Conversation

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Fixes: #13094

  • In a late minute change to the ILStrip PR ([msbuild] Add ILStrip'ing for net6 applications. Fixes #11445. #12563) a change to support XVS support broke execution of Apps that were stripped
  • Applications were broken because none of the stripped assemblies were actually copied into the bundle
  • However, the tests still passed, because all assemblies that were there had no IL (zero assemblies total)

Now why did this happen?

  • The stripped assemblies were changed to return via an msbuild Output Element
  • Output Element can return an Property or ItemGroup, depending if you use the PropertyName or ItemName attributes
  • Unfortunately I used PropertyName, when I expected an ItemGroup. So I silently had a property created instead.
  • Thus zero items were added to the list of files to copy into the bundle
  • Which was undetected as the test did not confirm files were copied in, and manual tests were not run so late into the PR (3 weeks after PR was opened)

How was it fixed?

  • Correctly using ItemName on Output created a valid item group to reference
  • However, that still failed with an absurdly confusing error:
 PATH/Microsoft.NET.Publish.targets(277,5): error MSB3024: Could not copy the file FILE to the destination file PATH, because the destination is a folder instead of a file. To copy the source file into a folder, consider using the DestinationFolder parameter instead of DestinationFiles.
  • After a splunking through netcore targets, I found the metadata on these assemblies references really matters. Without it, they are not processed correctly at all.
  • Thus, I updated ILStripBase to clone the existing metadata when changing the original assembly reference to the stripped path
  • Finally, I corrected the test to assert that required files are copied in. I also manually ran our device test.

Backport of #13098

chamons and others added 2 commits October 25, 2021 16:58
- In a late minute change to the ILStrip PR (dotnet#12563) a change to support XVS support broke execution of Apps that were stripped
- Applications were broken because none of the stripped assemblies were actually copied into the bundle
- However, the tests still passed, because all assemblies that were there had no IL (zero assemblies total)

Now why did this happen?
- The stripped assemblies were changed to return via an msbuild Output Element
- Output Element can return an Property or ItemGroup, depending if you use the PropertyName or ItemName attributes
- Unfortunately I used PropertyName, when I expected an ItemGroup. So I silently had a property created instead.
- Thus zero items were added to the list of files to copy into the bundle
- Which was undetected as the test did not confirm files were copied in, and manual tests were not run so late into the PR (3 weeks after PR was opened)

How was it fixed?
- Correctly using ItemName on Output created a valid item group to reference
- However, that still failed with an absurdly confusing error:

 PATH/Microsoft.NET.Publish.targets(277,5): error MSB3024: Could not copy the file FILE to the destination file PATH, because the destination is a folder instead of a file. To copy the source file into a folder, consider using the DestinationFolder parameter instead of DestinationFiles.

- After a splunking through netcore targets, I found the metadata on these assemblies references really matters. Without it, they are not processed correctly at all.
- Thus, I updated ILStripBase to clone the existing metadata when changing the original assembly reference to the stripped path
- Finally, I corrected the test to assert that required files are copied in. I also manually ran our device test.
Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>
@vs-mobiletools-engineering-service2
Copy link
Collaborator Author

✅ [PR Build] Tests passed on Build. ✅

Tests passed on Build.

API diff

✅ API Diff from stable

View API diff
View dotnet API diff
View dotnet legacy API diff
View dotnet iOS-MacCatalayst API diff

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

🎉 All 132 tests passed 🎉

Pipeline on Agent XAMBOT-1104.BigSur'
Merge 729c5d2 into 5d53aa6

@dalexsoto dalexsoto merged commit 48f57c6 into dotnet:release/6.0.1xx-preview10 Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backported not-notes-worthy Ignore for release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants